You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "jin xing (Jira)" <ji...@apache.org> on 2019/09/18 04:02:00 UTC

[jira] [Created] (CALCITE-3357) Trivial null checking in RelSet#addAbstractConverters

jin xing created CALCITE-3357:
---------------------------------

             Summary: Trivial null checking in RelSet#addAbstractConverters
                 Key: CALCITE-3357
                 URL: https://issues.apache.org/jira/browse/CALCITE-3357
             Project: Calcite
          Issue Type: Bug
          Components: core
            Reporter: jin xing


In current code of *RelSet#addAbstractConverters*, null checking of *curRelTrait* happens after clause of assert *curRelTrait.getTraitDef() == traitDef*;

It makes more sense to adjust the order;

In my understanding, this issue was not found previously for two reasons:
 # AbstractConverter is not enabled by default ([https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableConvention.java#L65])
 # It rarely happens that two algebra expression operators have identical semantics but different *RelTraitDef*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)