You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/24 17:12:12 UTC

[GitHub] [arrow] Joey9801 opened a new pull request #9308: [Rust] Fix unused variable in code example

Joey9801 opened a new pull request #9308:
URL: https://github.com/apache/arrow/pull/9308


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #9308: [Rust] Fix unused variable in code example

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9308:
URL: https://github.com/apache/arrow/pull/9308#issuecomment-776293581


   I have created a new PR with this change https://github.com/apache/arrow/pull/9459 rebased against master


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #9308: [Rust] Fix unused variable in code example

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9308:
URL: https://github.com/apache/arrow/pull/9308#issuecomment-767501220


   Thanks @Joey9801 ! This is great. I am not sure what happened (the force push of master for the 3.0 release perhaps made a mess). Can you please rebase it against master?
   
   A JIRA ticket is part of the process for each thing merged however small. However, I can make one for tracking prior to merge if you don't get to it
   
   https://github.com/apache/arrow/pull/9308/commits/3a380a4c4193c6683a71ba72dc31f8456bc661d5 looks great. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] Joey9801 commented on pull request #9308: [Rust] Fix unused variable in code example

Posted by GitBox <gi...@apache.org>.
Joey9801 commented on pull request #9308:
URL: https://github.com/apache/arrow/pull/9308#issuecomment-766396406


   I'm not sure this fix is substantial enough that it really needs a JIRA ticket. Happy to make one and link it to this PR if I'm wrong about that though!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] Joey9801 commented on pull request #9308: [Rust] Fix unused variable in code example

Posted by GitBox <gi...@apache.org>.
Joey9801 commented on pull request #9308:
URL: https://github.com/apache/arrow/pull/9308#issuecomment-766396406


   I'm not sure this fix is substantial enough that it really needs a JIRA ticket. Happy to make one and link it to this PR if I'm wrong about that though!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nevi-me commented on pull request #9308: [Rust] Fix unused variable in code example

Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9308:
URL: https://github.com/apache/arrow/pull/9308#issuecomment-777707349


   Fixed in #9459 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nevi-me closed pull request #9308: [Rust] Fix unused variable in code example

Posted by GitBox <gi...@apache.org>.
nevi-me closed pull request #9308:
URL: https://github.com/apache/arrow/pull/9308


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org