You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Kiritsgu (via GitHub)" <gi...@apache.org> on 2024/07/12 08:15:26 UTC
[PR] Verify functions from #31549 and add tests [shardingsphere]
Kiritsgu opened a new pull request, #32079:
URL: https://github.com/apache/shardingsphere/pull/32079
Fixes #31549.
Changes proposed in this pull request:
-
- I've verified if the SQL itself can be parsed by the parser
- Added dd the corresponding sql-case and case assertions.
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [x] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify functions from #31549 and add tests [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #32079:
URL: https://github.com/apache/shardingsphere/pull/32079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify functions from #31549 and add tests [shardingsphere]
Posted by "Kiritsgu (via GitHub)" <gi...@apache.org>.
Kiritsgu commented on PR #32079:
URL: https://github.com/apache/shardingsphere/pull/32079#issuecomment-2225171543
Since I encountered difficulties merging the code on the web, I would like to resolve the conflicts locally and then reopen this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify functions from #31549 and add tests [shardingsphere]
Posted by "Kiritsgu (via GitHub)" <gi...@apache.org>.
Kiritsgu closed pull request #32079: Verify functions from #31549 and add tests
URL: https://github.com/apache/shardingsphere/pull/32079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify functions from #31549 and add tests [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on PR #32079:
URL: https://github.com/apache/shardingsphere/pull/32079#issuecomment-2225158125
Why close this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify functions from #31549 and add tests [shardingsphere]
Posted by "Kiritsgu (via GitHub)" <gi...@apache.org>.
Kiritsgu commented on PR #32079:
URL: https://github.com/apache/shardingsphere/pull/32079#issuecomment-2225194304
@strongduanmu
I have resolved the code conflicts. Please take a look when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org