You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/06 06:47:17 UTC

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #343: test: add DP test cases in traffic split e2e

tokers opened a new pull request #343:
URL: https://github.com/apache/apisix-ingress-controller/pull/343


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   
   ___
   ### Bugfix
   - Description
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   
   ___
   ### Backport patches
   - Why need to backport?
   
   - Source branch
   
   - Related commits and pull requests
   
   - Target branch
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #343: test: add DP test cases in traffic split e2e

Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #343:
URL: https://github.com/apache/apisix-ingress-controller/pull/343#discussion_r607711666



##########
File path: test/e2e/features/traffic_split.go
##########
@@ -47,47 +49,44 @@ spec:
      hosts:
      - httpbin.org
      paths:
-       - /ip
+       - /get
    backends:
    - serviceName: %s
      servicePort: %d
      weight: 10
-   - serviceName: %s
-     servicePort: %d
+   - serviceName: apisix-service-e2e-test
+     servicePort: 9180
      weight: 5
-`, backendSvc, backendPorts[0], backendSvc, backendPorts[0])
+`, backendSvc, backendPorts[0])

Review comment:
       Why not use variables?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #343: test: add DP test cases in traffic split e2e

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #343:
URL: https://github.com/apache/apisix-ingress-controller/pull/343#discussion_r608282830



##########
File path: test/e2e/features/traffic_split.go
##########
@@ -47,47 +49,44 @@ spec:
      hosts:
      - httpbin.org
      paths:
-       - /ip
+       - /get
    backends:
    - serviceName: %s
      servicePort: %d
      weight: 10
-   - serviceName: %s
-     servicePort: %d
+   - serviceName: apisix-service-e2e-test
+     servicePort: 9180
      weight: 5
-`, backendSvc, backendPorts[0], backendSvc, backendPorts[0])
+`, backendSvc, backendPorts[0])

Review comment:
       OK, will use it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on pull request #343: test: add DP test cases in traffic split e2e

Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #343:
URL: https://github.com/apache/apisix-ingress-controller/pull/343#issuecomment-816556021


   Ping @gxthrj 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #343: test: add DP test cases in traffic split e2e

Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #343:
URL: https://github.com/apache/apisix-ingress-controller/pull/343


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org