You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/08 10:03:18 UTC
[jira] [Commented] (BROOKLYN-516) WindowsPerformanceCounterSensors
does not start on rebind
[ https://issues.apache.org/jira/browse/BROOKLYN-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042492#comment-16042492 ]
ASF GitHub Bot commented on BROOKLYN-516:
-----------------------------------------
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-server/pull/724
[BROOKLYN-516] Persist feed of WindowsPerformanceCounterSensors initializer
Also make WindowsPerformanceCounterFeed$GetPerformanceCountersJob to not throw
exception when no machine is found.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/brooklyn-server windows-counters
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/724.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #724
----
commit b8a0fb59893f605d8ef20ce6e92d3de7f4a75f73
Author: Valentin Aitken <bo...@gmail.com>
Date: 2017-06-08T10:00:07Z
[BROOKLYN-516] Persist feed of WindowsPerformanceCounterSensors initializer
commit 4905f3a2b073ffc5bd2c93a5f2ab106be5c6e625
Author: Valentin Aitken <bo...@gmail.com>
Date: 2017-06-08T10:01:19Z
WindowsPerformanceCounterFeed$GetPerformanceCountersJob do not throw exception
when no machine is found.
----
> WindowsPerformanceCounterSensors does not start on rebind
> ---------------------------------------------------------
>
> Key: BROOKLYN-516
> URL: https://issues.apache.org/jira/browse/BROOKLYN-516
> Project: Brooklyn
> Issue Type: Bug
> Reporter: Valentin Aitken
>
> Scenario:
> # Launch Apache Brooklyn with enabled persistence. (Use karaf build or classic build with {{--persist auto}} flags)
> # Deploy a blueprint with WindowsPerformanceCounterSensors initializer
> {noformat}
> - type: org.apache.brooklyn.entity.software.base.VanillaWindowsProcess
> brooklyn.initializers:
> - type: org.apache.brooklyn.core.sensor.windows.WindowsPerformanceCounterSensors
> brooklyn.config:
> performance.counters:
> - name: percent.processor.time
> description: '% Processor Time'
> counter: \Processor Information(_total)\% Processor Time
> {noformat}
> # Restart Apache Brooklyn
> # After restart {{percent.processor.time}} never changes
> ---
> Currently poll job is added on preStart.
> I think the fix would be similarly to {{org.apache.brooklyn.core.sensor.windows.WinRmCommandSensor}} to wrap the poll job in a feed and add the feed to the entity.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)