You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/10 02:13:59 UTC

[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #5429: [INLONG-5377][Sort] Add reporting metrics for kafka connector sink and audit SDK

yunqingmoswu commented on code in PR #5429:
URL: https://github.com/apache/inlong/pull/5429#discussion_r941945293


##########
inlong-sort/sort-connectors/kafka/src/main/java/org/apache/inlong/sort/kafka/table/KafkaInLongOptions.java:
##########
@@ -22,8 +22,8 @@
 import org.apache.flink.configuration.ConfigOptions;
 
 /** Option utils for Kafka table source sink. */
-public class KafkaOptions {
-    private KafkaOptions() {
+public class KafkaInLongOptions {

Review Comment:
   This refactoring doesn't make sense, it is recommended to keep it as it is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org