You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/12/29 06:24:18 UTC

[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #2732: [Enhancement] Method calls keySet() just to call contains, use containsKey instead [EventMeshRecommendImpl]

Alonexc opened a new issue, #2732:
URL: https://github.com/apache/incubator-eventmesh/issues/2732

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Enhancement Request
   
   ![image](https://user-images.githubusercontent.com/91315508/209911638-0baf3859-b67a-43de-8dd8-08efb496c356.png)
   located at:
   eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/recommend/EventMeshRecommendImpl.java line 186,192
   analysis and explanation:
   This method calls mySet.keySet().contains("foo") when mySet.containsKey("foo") is simpler.
   
   
   ### Describe the solution you'd like
   
   reference:
   ![image](https://user-images.githubusercontent.com/91315508/209911676-d255b922-ba62-41b5-a343-e6a0b4a280e9.png)
   
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] jonyangx closed issue #2732: [Enhancement] Method calls keySet() just to call contains, use containsKey instead [EventMeshRecommendImpl]

Posted by GitBox <gi...@apache.org>.

jonyangx closed issue #2732: [Enhancement] Method calls keySet() just to call contains, use containsKey instead [EventMeshRecommendImpl]
URL: https://github.com/apache/incubator-eventmesh/issues/2732


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] jonyangx commented on issue #2732: [Enhancement] Method calls keySet() just to call contains, use containsKey instead [EventMeshRecommendImpl]

Posted by GitBox <gi...@apache.org>.

jonyangx commented on issue #2732:
URL: https://github.com/apache/incubator-eventmesh/issues/2732#issuecomment-1368625200

   I want to fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org