[GitHub] [helix] xyuanlu commented on a change in pull request #1511: Refine Task Framework log format part-1

[GitBox <gi...@apache.org>]

xyuanlu commented on a change in pull request #1511:
URL: https://github.com/apache/helix/pull/1511#discussion_r518939345



##########
File path: helix-core/src/main/java/org/apache/helix/task/AbstractTaskDispatcher.java
##########
@@ -192,11 +191,8 @@ public void updatePreviousAssignedTasksStatus(
             paMap.put(pId, new PartitionAssignment(instance, requestedState.name()));
           }
           assignedPartitions.get(instance).add(pId);
-          if (LOG.isDebugEnabled()) {

Review comment:
       I do think so. Since this check is no longer needed after using slf4j.Logger. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org