[GitHub] [flink-web] matriv commented on a diff in pull request #504: [FLINK-25897] Update gradle quickstart to gradle 7.3.3

[GitBox <gi...@apache.org>]

matriv commented on code in PR #504:
URL: https://github.com/apache/flink-web/pull/504#discussion_r841553926


##########
q/gradle-quickstart.sh:
##########
@@ -169,17 +168,23 @@ dependencies {
     // Compile-time dependencies that should NOT be part of the
     // shadow jar and are provided in the lib folder of Flink
     // --------------------------------------------------------------
-    compile "org.apache.flink:flink-java:\${flinkVersion}"
-    compile "org.apache.flink:flink-streaming-java_\${scalaBinaryVersion}:\${flinkVersion}"
+    if (flinkVersionNew) {
+        implementation "org.apache.flink:flink-streaming-java:\${flinkVersion}"
+        implementation "org.apache.flink:flink-clients:\${flinkVersion}"
+    } else {
+        implementation "org.apache.flink:flink-streaming-java_\${scalaBinaryVersion}:\${flinkVersion}"
+        implementation "org.apache.flink:flink-clients_\${scalaBinaryVersion}:${flinkVersion}"

Review Comment:
   Thx for catching that, but somehow, when testing the script it worked without the escape.
   Anyways, fixed it, Thx!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org