You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "carloea2 (via GitHub)" <gi...@apache.org> on 2026/08/31 05:22:21 UTC
[PR] fix(pyamber): preserve minus-one shuffle hashes [texera]
carloea2 opened a new pull request, #8254:
URL: https://github.com/apache/texera/pull/8254
## What changed
Hash shuffle now uses the tuple's raw Java-compatible hash method directly, avoiding Python's reserved `-1` to `-2` normalization before receiver selection.
Closes #8253
## How was this PR tested?
```text
python -c "import sys,pytest; sys.path[:0]=[r'C:\Users\carlo\texera\texera-worktrees\investigate-bug63\amber\src\main\python',r'C:\Users\carlo\texera\texera\amber\src\main\python']; raise SystemExit(pytest.main(['amber/src/test/python/core/architecture/sendsemantics/test_partitioners.py','-q','-p','no:cacheprovider']))"
36 passed
ruff check amber/src/main/python amber/src/test/python
All checks passed
ruff format --check amber/src/main/python amber/src/test/python
213 files already formatted
```
Direct reproduction after the fix:
```text
raw_java_hash=-1 builtin_hash=-2 receiver=B
```
Generated-by: Codex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(pyamber): preserve minus-one shuffle hashes [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #8254:
URL: https://github.com/apache/texera/pull/8254#issuecomment-6303872169
Could you review this small change when you have time?
/request-review @sshiv012 @parshimers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pyamber): preserve minus-one shuffle hashes [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8254:
URL: https://github.com/apache/texera/pull/8254#issuecomment-5474135818
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 2 better · 🔴 3 worse · ⚪ 10 noise (<±5%) · 0 without baseline
> Compared against main `50321e4` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/33360320889)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 636 | 0.388 | 15,563/19,425/19,425 us | 🟢 -45.9% / 🔴 +31.5% |
| 🔴 | bs=100 sw=10 sl=64 | 1,299 | 0.793 | 74,943/106,481/106,481 us | 🔴 +16.9% / 🟢 -20.7% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,544 | 0.943 | 646,152/726,496/726,496 us | ⚪ within ±5% / 🟢 +38.0% |
<details><summary>Baseline details</summary>
Latest main `50321e4` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 636 tuples/sec | 626 tuples/sec | 844.57 tuples/sec | +1.6% | -24.7% |
| bs=10 sw=10 sl=64 | MB/s | 0.388 MB/s | 0.382 MB/s | 0.515 MB/s | +1.6% | -24.7% |
| bs=10 sw=10 sl=64 | p50 | 15,563 us | 13,164 us | 11,837 us | +18.2% | +31.5% |
| bs=10 sw=10 sl=64 | p95 | 19,425 us | 35,926 us | 14,788 us | -45.9% | +31.4% |
| bs=10 sw=10 sl=64 | p99 | 19,425 us | 35,926 us | 17,651 us | -45.9% | +10.1% |
| bs=100 sw=10 sl=64 | throughput | 1,299 tuples/sec | 1,317 tuples/sec | 1,084 tuples/sec | -1.4% | +19.8% |
| bs=100 sw=10 sl=64 | MB/s | 0.793 MB/s | 0.804 MB/s | 0.662 MB/s | -1.4% | +19.9% |
| bs=100 sw=10 sl=64 | p50 | 74,943 us | 75,914 us | 94,505 us | -1.3% | -20.7% |
| bs=100 sw=10 sl=64 | p95 | 106,481 us | 91,071 us | 100,941 us | +16.9% | +5.5% |
| bs=100 sw=10 sl=64 | p99 | 106,481 us | 91,071 us | 108,642 us | +16.9% | -2.0% |
| bs=1000 sw=10 sl=64 | throughput | 1,544 tuples/sec | 1,506 tuples/sec | 1,119 tuples/sec | +2.5% | +37.9% |
| bs=1000 sw=10 sl=64 | MB/s | 0.943 MB/s | 0.919 MB/s | 0.683 MB/s | +2.6% | +38.0% |
| bs=1000 sw=10 sl=64 | p50 | 646,152 us | 657,707 us | 924,404 us | -1.8% | -30.1% |
| bs=1000 sw=10 sl=64 | p95 | 726,496 us | 754,360 us | 967,785 us | -3.7% | -24.9% |
| bs=1000 sw=10 sl=64 | p99 | 726,496 us | 754,360 us | 995,630 us | -3.7% | -27.0% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,314.36,200,128000,636,0.388,15562.76,19425.41,19425.41
1,100,10,64,20,1539.83,2000,1280000,1299,0.793,74942.60,106481.47,106481.47
2,1000,10,64,20,12950.94,20000,12800000,1544,0.943,646152.24,726496.06,726496.06
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pyamber): preserve minus-one shuffle hashes [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #8254:
URL: https://github.com/apache/texera/pull/8254#issuecomment-5484007801
The description now follows the current template, and this is ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pyamber): preserve minus-one shuffle hashes [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8254:
URL: https://github.com/apache/texera/pull/8254#issuecomment-5474127008
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8254?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 93.38%. Comparing base ([`50321e4`](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`02bcf80`](https://app.codecov.io/gh/apache/texera/commit/02bcf8080c54244365605fe38e465255104b2faf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8254 +/- ##
============================================
- Coverage 93.93% 93.38% -0.56%
Complexity 4761 4761
============================================
Files 1191 1189 -2
Lines 48308 47922 -386
Branches 5377 5377
============================================
- Hits 45378 44751 -627
- Misses 1495 1736 +241
Partials 1435 1435
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8254/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8254/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.00% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8254/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.32% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8254/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.02% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8254/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.67% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8254/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `86.86% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8254/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.91% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8254/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.41% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8254/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.31% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8254/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `93.07% <ø> (-5.80%)` | :arrow_down: | |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8254/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.19% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8254?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pyamber): preserve minus-one shuffle hashes [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8254:
URL: https://github.com/apache/texera/pull/8254#issuecomment-5474101853
<!-- texera:template-compliance -->
👋 Thanks for opening this pull request, @carloea2!
It looks like the pull request description doesn't quite follow our template yet:
- The **What changes were proposed in this PR?** section is missing; please keep the template's headings.
- The **Was this PR authored or co-authored using generative AI tooling?** section is missing; please keep the template's headings.
Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pyamber): preserve minus-one shuffle hashes [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8254:
URL: https://github.com/apache/texera/pull/8254#issuecomment-5474102229
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@Ma77Ball`, `@Yicong-Huang`
You can notify them by mentioning `@Ma77Ball`, `@Yicong-Huang` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(pyamber): preserve minus-one shuffle hashes [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #8254:
URL: https://github.com/apache/texera/pull/8254#issuecomment-6303909124
/request-review @sshiv012 @parshimers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pyamber): preserve minus-one shuffle hashes [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8254:
URL: https://github.com/apache/texera/pull/8254#issuecomment-5474102493
<!-- backport-auto-label-report -->
### Backport auto-label report
This `fix:` PR was checked against each actively-supported release branch. `release/*` labels drive the post-merge backport, so add or remove one to change where this fix lands.
| Release branch | Analysis |
| --- | --- |
| ⚠️ `release/v1.3` | Not labeled automatically — none of the files this PR modifies exist on this branch (`amber/src/main/python/core/architecture/sendsemantics/hash_based_shuffle_partitioner.py`, `amber/src/test/python/core/architecture/sendsemantics/test_partitioners.py`). The fix may target code that isn't on this release, or the files were moved/renamed after the branch was cut. **Please check and add `release/v1.3` by hand if this fix should be backported here.** |
| ✅ `release/v1.2` | Change detected on this branch — label added; this fix is queued to backport here. Requested review from @xuang7. |
_[Auto-label run](https://github.com/apache/texera/actions/runs/33360308525)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pyamber): preserve minus-one shuffle hashes [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #8254:
URL: https://github.com/apache/texera/pull/8254#issuecomment-5483857162
I am converting this PR to a draft: please follow our PR template and mark it ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org