[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1590: Implement BetaRowsetWriter

[GitBox <gi...@apache.org>]

kangpinghuang commented on a change in pull request #1590: Implement BetaRowsetWriter
URL: https://github.com/apache/incubator-doris/pull/1590#discussion_r312817232
 
 

 ##########
 File path: be/src/olap/rowset/beta_rowset_writer.h
 ##########
 @@ -0,0 +1,89 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#ifndef DORIS_BE_SRC_OLAP_ROWSET_BETA_ROWSET_WRITER_H
+#define DORIS_BE_SRC_OLAP_ROWSET_BETA_ROWSET_WRITER_H
+
+#include "olap/rowset/rowset_writer.h"
+
+namespace doris {
+
+namespace segment_v2 {
+class SegmentWriter;
+} // namespace segment_v2
+
+class BetaRowsetWriter : public RowsetWriter {
+public:
+    BetaRowsetWriter();
+
+    ~BetaRowsetWriter() override;
+
+    OLAPStatus init(const RowsetWriterContext& rowset_writer_context) override;
+
+    OLAPStatus add_row(const RowCursor& row) override {
+        return _add_row(row);
+    }
+    OLAPStatus add_row(const ContiguousRow& row) override {
+        return _add_row(row);
+    }
+
+    // add rowset by create hard link
+    OLAPStatus add_rowset(RowsetSharedPtr rowset) override;
+
+    OLAPStatus add_rowset_for_linked_schema_change(
+        RowsetSharedPtr rowset, const SchemaMapping& schema_mapping) override;
+
+    OLAPStatus flush() override;
+
+    RowsetSharedPtr build() override;
+
+    Version version() override { return _context.version; }
 
 Review comment:
   const

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org