You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2025/10/27 21:08:34 UTC

[PR] Valhalla Awaits [netbeans]

mbien opened a new pull request, #8964:
URL: https://github.com/apache/netbeans/pull/8964

   Some more changes required for minimal value object compatibility. NB starts and projects load at least.
   
   Works better than anticipated - looks like we caught most issues during the renovations :)
   
   PR just for testing purposes for now
   
   JDK: `26-jep401ea2+1-1`
   set  `-J--enable-preview` on start
   
   meta issue https://github.com/apache/netbeans/issues/8256


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Master Filesystem Valhalla compatibility [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8964:
URL: https://github.com/apache/netbeans/pull/8964#issuecomment-3504559897

   all green, ran a indexer smoke test which indexed all ~850 nb modules using 26-jep401ea and checked a few things manually (eg some dialogs due to https://github.com/apache/netbeans/pull/8799) everything worked as before.
   
   thanks for the review -> merging


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Master Filesystem Valhalla compatibility [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8964:
URL: https://github.com/apache/netbeans/pull/8964#issuecomment-3476626676

   while renovating the code I found more issues in `FileObjectFactory` but addressing them would be out of scope of this PR.
   
   E.g the list entry of the internal cache can't shrink atm. There is also an instance identity problem which could cause the `WeakHashMap` to remove a full List entry even though some of the list items are still alive. I might do some more cleanup as preparation for the fixes though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Valhalla Awaits [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8964:
URL: https://github.com/apache/netbeans/pull/8964#issuecomment-3455577753

   > The errors from these issues must have been silently thrown because Netbeans 27 started just fine for me. The IDE did crash everytime the editor's context menu was opened though.
   > 
   > Of course Netbeans was also highlighted perfectly fine code as having errors. I could've sworn removing `nb-javac` worked around that last EA build but maybe not.
   
   This is not about editor support for JDK 26 or any editor features regarding value types. This PR so far is just here to allow (very) early testing of running NB on ea JDKs which have the JEP 401 implementation enabled.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Master Filesystem Valhalla compatibility [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8964:
URL: https://github.com/apache/netbeans/pull/8964#issuecomment-3481776029

   will rebase on top of https://github.com/apache/netbeans/pull/8799 so that we can test both valhalla related updates using the same dev build
   
   planning to integrate this this week, dependent on feedback. Thanks for the review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Valhalla Awaits [netbeans]

Posted by "BlueGoliath (via GitHub)" <gi...@apache.org>.
BlueGoliath commented on PR #8964:
URL: https://github.com/apache/netbeans/pull/8964#issuecomment-3454035629

   The errors from these issues must have been silently thrown because Netbeans 27 started just fine for me. The IDE did crash everytime the editor's context menu was opened though.
   
   Of course Netbeans was also highlighted perfectly fine code as having errors. I could've sworn removing `nb-javac` worked around that last EA build but maybe not.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Master Filesystem Valhalla compatibility [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #8964:
URL: https://github.com/apache/netbeans/pull/8964


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists