You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/25 06:51:29 UTC
[GitHub] [apisix] qihaiyan opened a new issue, #6923: feat: As a user, I want to let api-breaker plugin return default response body
qihaiyan opened a new issue, #6923:
URL: https://github.com/apache/apisix/issues/6923
### Description
refer to the document [api-breaker](https://apisix.apache.org/docs/apisix/plugins/api-breaker)
when upstream is in the unhealthy state, the api-breaker returns unhealthy.http_statuses only, without a response body.
In order to be more compatible to the client, return a default response body is useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander closed issue #6923: feat: As a user, I want to let api-breaker plugin return default response body
Posted by GitBox <gi...@apache.org>.
spacewander closed issue #6923: feat: As a user, I want to let api-breaker plugin return default response body
URL: https://github.com/apache/apisix/issues/6923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on issue #6923: feat: As a user, I want to let api-breaker plugin return default response body
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #6923:
URL: https://github.com/apache/apisix/issues/6923#issuecomment-1108271290
Sound good, which value do you think is reasonable for the default response body?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on issue #6923: feat: As a user, I want to let api-breaker plugin return default response body
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #6923:
URL: https://github.com/apache/apisix/issues/6923#issuecomment-1109190860
> > Sound good, which value do you think is reasonable for the default response body?
>
> Different api may return different default value. Users should specify the default value with admin api, and the plugin api could add a new param like unhealthy.http_response_body
I think a field like `break_response_body` can be added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] qihaiyan commented on issue #6923: feat: As a user, I want to let api-breaker plugin return default response body
Posted by GitBox <gi...@apache.org>.
qihaiyan commented on issue #6923:
URL: https://github.com/apache/apisix/issues/6923#issuecomment-1108326148
> Sound good, which value do you think is reasonable for the default response body?
Different api may return different default value. Users should specify the default value with admin api, and the plugin api could add a new param like unhealthy.http_response_body
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on issue #6923: feat: As a user, I want to let api-breaker plugin return default response body
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #6923:
URL: https://github.com/apache/apisix/issues/6923#issuecomment-1109439893
> > > > Sound good, which value do you think is reasonable for the default response body?
> > >
> > >
> > > Different api may return different default value. Users should specify the default value with admin api, and the plugin api could add a new param like unhealthy.http_response_body
> >
> >
> > I think a field like `break_response_body` can be added.
>
> I could make a pr for this, if you don't mind. @tokers
Sure, assigned to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] qihaiyan commented on issue #6923: feat: As a user, I want to let api-breaker plugin return default response body
Posted by GitBox <gi...@apache.org>.
qihaiyan commented on issue #6923:
URL: https://github.com/apache/apisix/issues/6923#issuecomment-1109248935
> > > Sound good, which value do you think is reasonable for the default response body?
> >
> >
> > Different api may return different default value. Users should specify the default value with admin api, and the plugin api could add a new param like unhealthy.http_response_body
>
> I think a field like `break_response_body` can be added.
I could make a pr for this, if you don't mind. @tokers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org