You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jeff Trawick <tr...@gmail.com> on 2011/04/26 21:57:44 UTC
Re: svn commit: r1057048 - in /httpd/httpd/trunk: CHANGES modules/generators/mod_status.c
On Sun, Jan 9, 2011 at 6:00 PM, <sf...@apache.org> wrote:
> Author: sf
> Date: Sun Jan 9 23:00:33 2011
> New Revision: 1057048
>
> URL: http://svn.apache.org/viewvc?rev=1057048&view=rev
> Log:
> mod_status: Don't show slots which are disabled by MaxClients as open.
They now get displayed as ' ' instead of '.'.
No complaints here about not displaying unused slots as open, but the
result can look a bit odd.
---------cut here-----------
1 requests currently being processed, 49 idle workers
_________________________
______W__________________
Scoreboard Key:
-----------cut here--------------
On Windows, with huge default ThreadLimit relative to ThreadsPerChild,
you're left with lots of unexpected whitespace.
What about just surpressing the ' ' when printing out the worker map?
After a graceful restart which shrinks MaxClients or ThreadsPerChild
you might have the map gradually get smaller for a short time as
workers in those "beyond" scoreboard entries exit, but generally it
would look better.
Comments? (Do folks want the space used to reflect ThreadLimit * ServerLimit?)
> Modified: httpd/httpd/trunk/modules/generators/mod_status.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/generators/mod_status.c?rev=1057048&r1=1057047&r2=1057048&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/generators/mod_status.c (original)
> +++ httpd/httpd/trunk/modules/generators/mod_status.c Sun Jan 9 23:00:33 2011
> @@ -483,7 +492,8 @@ static int status_handler(request_rec *r
> ap_rputs("\"<b><code>L</code></b>\" Logging, \n", r);
> ap_rputs("\"<b><code>G</code></b>\" Gracefully finishing,<br /> \n", r);
> ap_rputs("\"<b><code>I</code></b>\" Idle cleanup of worker, \n", r);
> - ap_rputs("\"<b><code>.</code></b>\" Open slot with no current process</p>\n", r);
> + ap_rputs("\"<b><code>.</code></b>\" Open slot with no current process,<br />\n", r);
> + ap_rputs("\"<b><code> </code></b>\" Slot disabled by MaxClients setting</p>\n", r);
(and/or by ThreadsPerChild)
Re: svn commit: r1057048 - in /httpd/httpd/trunk: CHANGES modules/generators/mod_status.c
Posted by Rainer Jung <ra...@kippdata.de>.
On 26.04.2011 21:57, Jeff Trawick wrote:
> On Sun, Jan 9, 2011 at 6:00 PM,<sf...@apache.org> wrote:
>> Author: sf
>> Date: Sun Jan 9 23:00:33 2011
>> New Revision: 1057048
>>
>> URL: http://svn.apache.org/viewvc?rev=1057048&view=rev
>> Log:
>> mod_status: Don't show slots which are disabled by MaxClients as open.
>
> They now get displayed as ' ' instead of '.'.
>
> No complaints here about not displaying unused slots as open, but the
> result can look a bit odd.
>
> ---------cut here-----------
> 1 requests currently being processed, 49 idle workers
>
> _________________________
> ______W__________________
>
>
>
> Scoreboard Key:
> -----------cut here--------------
>
> On Windows, with huge default ThreadLimit relative to ThreadsPerChild,
> you're left with lots of unexpected whitespace.
>
> What about just surpressing the ' ' when printing out the worker map?
>
> After a graceful restart which shrinks MaxClients or ThreadsPerChild
> you might have the map gradually get smaller for a short time as
> workers in those "beyond" scoreboard entries exit, but generally it
> would look better.
>
> Comments? (Do folks want the space used to reflect ThreadLimit * ServerLimit?)
>
>> Modified: httpd/httpd/trunk/modules/generators/mod_status.c
>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/generators/mod_status.c?rev=1057048&r1=1057047&r2=1057048&view=diff
>> ==============================================================================
>> --- httpd/httpd/trunk/modules/generators/mod_status.c (original)
>> +++ httpd/httpd/trunk/modules/generators/mod_status.c Sun Jan 9 23:00:33 2011
>
>> @@ -483,7 +492,8 @@ static int status_handler(request_rec *r
>> ap_rputs("\"<b><code>L</code></b>\" Logging, \n", r);
>> ap_rputs("\"<b><code>G</code></b>\" Gracefully finishing,<br /> \n", r);
>> ap_rputs("\"<b><code>I</code></b>\" Idle cleanup of worker, \n", r);
>> - ap_rputs("\"<b><code>.</code></b>\" Open slot with no current process</p>\n", r);
>> + ap_rputs("\"<b><code>.</code></b>\" Open slot with no current process,<br />\n", r);
>> + ap_rputs("\"<b><code> </code></b>\" Slot disabled by MaxClients setting</p>\n", r);
>
> (and/or by ThreadsPerChild)
I'd say the additional slots are more of an implementation detail
(pre-allocated to allow increasing the actual available processes and
threads by graceful restart) and do not provide relevant information for
mod_status. So I am +1 for dropping, but can live with white space too.
Regards,
Rainer
Re: svn commit: r1057048 - in /httpd/httpd/trunk: CHANGES modules/generators/mod_status.c
Posted by Stefan Fritsch <sf...@sfritsch.de>.
On Wednesday 27 April 2011, Jeff Trawick wrote:
> On Wed, Apr 27, 2011 at 12:27 PM, Jim Jagielski <ji...@jagunet.com>
wrote:
> > How does this affect the XML output (sorry, can't test
> > here)? Personally, I'm sure there are scripts that take
> > the output from server-status and parse it, and specifically
> > look for '.'... this will break those.
> >
> > (PS: Sorry if I'm missing out on the context of this
> > change...)
>
> You mean the short form ("/server-status?auto")?
>
> Before this a.m.'s tweak, there would be blanks within the
> scoreboard map (single line of K_.CRWetc.). Now the blanks are
> suppressed.
This is now what a script used to 2.2.x's output would expect.
Belatedly +1 for the fix. Thanks.
Re: svn commit: r1057048 - in /httpd/httpd/trunk: CHANGES modules/generators/mod_status.c
Posted by Jeff Trawick <tr...@gmail.com>.
On Wed, Apr 27, 2011 at 12:27 PM, Jim Jagielski <ji...@jagunet.com> wrote:
> How does this affect the XML output (sorry, can't test
> here)? Personally, I'm sure there are scripts that take
> the output from server-status and parse it, and specifically
> look for '.'... this will break those.
>
> (PS: Sorry if I'm missing out on the context of this
> change...)
You mean the short form ("/server-status?auto")?
Before this a.m.'s tweak, there would be blanks within the scoreboard
map (single line of K_.CRWetc.). Now the blanks are suppressed.
>
> On Apr 26, 2011, at 3:57 PM, Jeff Trawick wrote:
>
>> On Sun, Jan 9, 2011 at 6:00 PM, <sf...@apache.org> wrote:
>>> Author: sf
>>> Date: Sun Jan 9 23:00:33 2011
>>> New Revision: 1057048
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1057048&view=rev
>>> Log:
>>> mod_status: Don't show slots which are disabled by MaxClients as open.
>>
>> They now get displayed as ' ' instead of '.'.
>>
>> No complaints here about not displaying unused slots as open, but the
>> result can look a bit odd.
>>
>> ---------cut here-----------
>> 1 requests currently being processed, 49 idle workers
>>
>> _________________________
>> ______W__________________
>>
>>
>>
>> Scoreboard Key:
>> -----------cut here--------------
>>
>> On Windows, with huge default ThreadLimit relative to ThreadsPerChild,
>> you're left with lots of unexpected whitespace.
>>
>> What about just surpressing the ' ' when printing out the worker map?
>>
>> After a graceful restart which shrinks MaxClients or ThreadsPerChild
>> you might have the map gradually get smaller for a short time as
>> workers in those "beyond" scoreboard entries exit, but generally it
>> would look better.
>>
>> Comments? (Do folks want the space used to reflect ThreadLimit * ServerLimit?)
>>
>>> Modified: httpd/httpd/trunk/modules/generators/mod_status.c
>>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/generators/mod_status.c?rev=1057048&r1=1057047&r2=1057048&view=diff
>>> ==============================================================================
>>> --- httpd/httpd/trunk/modules/generators/mod_status.c (original)
>>> +++ httpd/httpd/trunk/modules/generators/mod_status.c Sun Jan 9 23:00:33 2011
>>
>>> @@ -483,7 +492,8 @@ static int status_handler(request_rec *r
>>> ap_rputs("\"<b><code>L</code></b>\" Logging, \n", r);
>>> ap_rputs("\"<b><code>G</code></b>\" Gracefully finishing,<br /> \n", r);
>>> ap_rputs("\"<b><code>I</code></b>\" Idle cleanup of worker, \n", r);
>>> - ap_rputs("\"<b><code>.</code></b>\" Open slot with no current process</p>\n", r);
>>> + ap_rputs("\"<b><code>.</code></b>\" Open slot with no current process,<br />\n", r);
>>> + ap_rputs("\"<b><code> </code></b>\" Slot disabled by MaxClients setting</p>\n", r);
>>
>> (and/or by ThreadsPerChild)
>>
>
>
--
Born in Roswell... married an alien...
Re: svn commit: r1057048 - in /httpd/httpd/trunk: CHANGES modules/generators/mod_status.c
Posted by Jim Jagielski <ji...@jaguNET.com>.
How does this affect the XML output (sorry, can't test
here)? Personally, I'm sure there are scripts that take
the output from server-status and parse it, and specifically
look for '.'... this will break those.
(PS: Sorry if I'm missing out on the context of this
change...)
On Apr 26, 2011, at 3:57 PM, Jeff Trawick wrote:
> On Sun, Jan 9, 2011 at 6:00 PM, <sf...@apache.org> wrote:
>> Author: sf
>> Date: Sun Jan 9 23:00:33 2011
>> New Revision: 1057048
>>
>> URL: http://svn.apache.org/viewvc?rev=1057048&view=rev
>> Log:
>> mod_status: Don't show slots which are disabled by MaxClients as open.
>
> They now get displayed as ' ' instead of '.'.
>
> No complaints here about not displaying unused slots as open, but the
> result can look a bit odd.
>
> ---------cut here-----------
> 1 requests currently being processed, 49 idle workers
>
> _________________________
> ______W__________________
>
>
>
> Scoreboard Key:
> -----------cut here--------------
>
> On Windows, with huge default ThreadLimit relative to ThreadsPerChild,
> you're left with lots of unexpected whitespace.
>
> What about just surpressing the ' ' when printing out the worker map?
>
> After a graceful restart which shrinks MaxClients or ThreadsPerChild
> you might have the map gradually get smaller for a short time as
> workers in those "beyond" scoreboard entries exit, but generally it
> would look better.
>
> Comments? (Do folks want the space used to reflect ThreadLimit * ServerLimit?)
>
>> Modified: httpd/httpd/trunk/modules/generators/mod_status.c
>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/generators/mod_status.c?rev=1057048&r1=1057047&r2=1057048&view=diff
>> ==============================================================================
>> --- httpd/httpd/trunk/modules/generators/mod_status.c (original)
>> +++ httpd/httpd/trunk/modules/generators/mod_status.c Sun Jan 9 23:00:33 2011
>
>> @@ -483,7 +492,8 @@ static int status_handler(request_rec *r
>> ap_rputs("\"<b><code>L</code></b>\" Logging, \n", r);
>> ap_rputs("\"<b><code>G</code></b>\" Gracefully finishing,<br /> \n", r);
>> ap_rputs("\"<b><code>I</code></b>\" Idle cleanup of worker, \n", r);
>> - ap_rputs("\"<b><code>.</code></b>\" Open slot with no current process</p>\n", r);
>> + ap_rputs("\"<b><code>.</code></b>\" Open slot with no current process,<br />\n", r);
>> + ap_rputs("\"<b><code> </code></b>\" Slot disabled by MaxClients setting</p>\n", r);
>
> (and/or by ThreadsPerChild)
>