You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by rh...@apache.org on 2014/12/12 18:11:05 UTC

qpid-proton git commit: fixed an embarrassing braino

Repository: qpid-proton
Updated Branches:
  refs/heads/master da226c858 -> 7ed445601


fixed an embarrassing braino


Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/7ed44560
Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/7ed44560
Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/7ed44560

Branch: refs/heads/master
Commit: 7ed445601c279d8655370e71b71635b12066c41e
Parents: da226c8
Author: Rafael Schloming <rh...@alum.mit.edu>
Authored: Fri Dec 12 12:09:51 2014 -0500
Committer: Rafael Schloming <rh...@alum.mit.edu>
Committed: Fri Dec 12 12:09:51 2014 -0500

----------------------------------------------------------------------
 proton-c/src/object/list.c          |  2 +-
 tests/python/proton_tests/engine.py | 14 ++++++++++++++
 2 files changed, 15 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/7ed44560/proton-c/src/object/list.c
----------------------------------------------------------------------
diff --git a/proton-c/src/object/list.c b/proton-c/src/object/list.c
index 05e16b4..899a4fd 100644
--- a/proton-c/src/object/list.c
+++ b/proton-c/src/object/list.c
@@ -76,7 +76,7 @@ void *pn_list_pop(pn_list_t *list)
 {
   assert(list);
   if (list->size) {
-    return list->elements[list->size--];
+    return list->elements[--list->size];
   } else {
     return NULL;
   }

http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/7ed44560/tests/python/proton_tests/engine.py
----------------------------------------------------------------------
diff --git a/tests/python/proton_tests/engine.py b/tests/python/proton_tests/engine.py
index 8205454..69cf101 100644
--- a/tests/python/proton_tests/engine.py
+++ b/tests/python/proton_tests/engine.py
@@ -2428,3 +2428,17 @@ class IdleTimeoutEventTest(PeerTest):
   def testTimeoutWithZombieServerAndSASL(self):
     sasl = self.transport.sasl()
     self.testTimeoutWithZombieServer()
+
+class DeliverySegFaultTest(Test):
+
+  def testDeliveryAfterUnbind(self):
+    conn = Connection()
+    t = Transport()
+    ssn = conn.session()
+    snd = ssn.sender("sender")
+    dlv = snd.delivery("tag")
+    dlv.settle()
+    del dlv
+    t.bind(conn)
+    t.unbind()
+    dlv = snd.delivery("tag")


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org