You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2010/04/16 14:06:25 UTC
[jira] Created: (LUCENE-2398) Improve tests to work easier from
IDEs
Improve tests to work easier from IDEs
--------------------------------------
Key: LUCENE-2398
URL: https://issues.apache.org/jira/browse/LUCENE-2398
Project: Lucene - Java
Issue Type: Test
Reporter: Robert Muir
Priority: Minor
Attachments: LUCENE-2398.patch
As reported by Paolo Castagna on the mailing lists, some tests fail when you run them from eclipse.
Some of the failures he reports are actually code problems such as base test classes not being
abstract when they should be... we should fix things like that.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2398) Improve tests to work easier from
IDEs
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857914#action_12857914 ]
Michael McCandless commented on LUCENE-2398:
--------------------------------------------
This is a great cleanup Robert! I love the copyToWorkDir...
> Improve tests to work easier from IDEs
> --------------------------------------
>
> Key: LUCENE-2398
> URL: https://issues.apache.org/jira/browse/LUCENE-2398
> Project: Lucene - Java
> Issue Type: Test
> Reporter: Robert Muir
> Priority: Minor
> Attachments: LUCENE-2398.patch, LUCENE-2398.patch, LUCENE-2398.patch
>
>
> As reported by Paolo Castagna on the mailing lists, some tests fail when you run them from eclipse.
> Some of the failures he reports are actually code problems such as base test classes not being
> abstract when they should be... we should fix things like that.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2398) Improve tests to work easier from
IDEs
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857942#action_12857942 ]
Robert Muir commented on LUCENE-2398:
-------------------------------------
Committed an additional fix: 935048, this allows you to run the contrib/ant tests from eclipse too.
> Improve tests to work easier from IDEs
> --------------------------------------
>
> Key: LUCENE-2398
> URL: https://issues.apache.org/jira/browse/LUCENE-2398
> Project: Lucene - Java
> Issue Type: Test
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2398.patch, LUCENE-2398.patch, LUCENE-2398.patch
>
>
> As reported by Paolo Castagna on the mailing lists, some tests fail when you run them from eclipse.
> Some of the failures he reports are actually code problems such as base test classes not being
> abstract when they should be... we should fix things like that.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2398) Improve tests to work easier from
IDEs
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved LUCENE-2398.
---------------------------------
Resolution: Fixed
Committed revision 935014.
> Improve tests to work easier from IDEs
> --------------------------------------
>
> Key: LUCENE-2398
> URL: https://issues.apache.org/jira/browse/LUCENE-2398
> Project: Lucene - Java
> Issue Type: Test
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2398.patch, LUCENE-2398.patch, LUCENE-2398.patch
>
>
> As reported by Paolo Castagna on the mailing lists, some tests fail when you run them from eclipse.
> Some of the failures he reports are actually code problems such as base test classes not being
> abstract when they should be... we should fix things like that.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2398) Improve tests to work easier from
IDEs
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857911#action_12857911 ]
Robert Muir commented on LUCENE-2398:
-------------------------------------
All tests pass with the latest patch, additionally I tested that the benchmark tests work from Eclipse.
If no one objects I would like to commit in a bit.
> Improve tests to work easier from IDEs
> --------------------------------------
>
> Key: LUCENE-2398
> URL: https://issues.apache.org/jira/browse/LUCENE-2398
> Project: Lucene - Java
> Issue Type: Test
> Reporter: Robert Muir
> Priority: Minor
> Attachments: LUCENE-2398.patch, LUCENE-2398.patch, LUCENE-2398.patch
>
>
> As reported by Paolo Castagna on the mailing lists, some tests fail when you run them from eclipse.
> Some of the failures he reports are actually code problems such as base test classes not being
> abstract when they should be... we should fix things like that.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2398) Improve tests to work easier from
IDEs
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2398:
--------------------------------
Fix Version/s: 3.1
Affects Version/s: 3.1
Lucene Fields: [New, Patch Available] (was: [New])
> Improve tests to work easier from IDEs
> --------------------------------------
>
> Key: LUCENE-2398
> URL: https://issues.apache.org/jira/browse/LUCENE-2398
> Project: Lucene - Java
> Issue Type: Test
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2398.patch, LUCENE-2398.patch, LUCENE-2398.patch
>
>
> As reported by Paolo Castagna on the mailing lists, some tests fail when you run them from eclipse.
> Some of the failures he reports are actually code problems such as base test classes not being
> abstract when they should be... we should fix things like that.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2398) Improve tests to work easier from
IDEs
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2398:
--------------------------------
Attachment: LUCENE-2398.patch
the attached patch refactors the benchmark tests:
* logic to run a benchmark test is moved to BenchmarkTestCase
* this forces them all to respect LuceneTestCase.TEMP_DIR for all file operations
* lucene.common.dir is removed
> Improve tests to work easier from IDEs
> --------------------------------------
>
> Key: LUCENE-2398
> URL: https://issues.apache.org/jira/browse/LUCENE-2398
> Project: Lucene - Java
> Issue Type: Test
> Reporter: Robert Muir
> Priority: Minor
> Attachments: LUCENE-2398.patch, LUCENE-2398.patch, LUCENE-2398.patch
>
>
> As reported by Paolo Castagna on the mailing lists, some tests fail when you run them from eclipse.
> Some of the failures he reports are actually code problems such as base test classes not being
> abstract when they should be... we should fix things like that.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-2398) Improve tests to work easier from
IDEs
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir reassigned LUCENE-2398:
-----------------------------------
Assignee: Robert Muir
> Improve tests to work easier from IDEs
> --------------------------------------
>
> Key: LUCENE-2398
> URL: https://issues.apache.org/jira/browse/LUCENE-2398
> Project: Lucene - Java
> Issue Type: Test
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2398.patch, LUCENE-2398.patch, LUCENE-2398.patch
>
>
> As reported by Paolo Castagna on the mailing lists, some tests fail when you run them from eclipse.
> Some of the failures he reports are actually code problems such as base test classes not being
> abstract when they should be... we should fix things like that.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2398) Improve tests to work easier from
IDEs
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2398:
--------------------------------
Attachment: LUCENE-2398.patch
attached is a patch that makes CollationTestBase, BaseTestLRU, and BenchmarkTestCase abstract, as a start.
> Improve tests to work easier from IDEs
> --------------------------------------
>
> Key: LUCENE-2398
> URL: https://issues.apache.org/jira/browse/LUCENE-2398
> Project: Lucene - Java
> Issue Type: Test
> Reporter: Robert Muir
> Priority: Minor
> Attachments: LUCENE-2398.patch
>
>
> As reported by Paolo Castagna on the mailing lists, some tests fail when you run them from eclipse.
> Some of the failures he reports are actually code problems such as base test classes not being
> abstract when they should be... we should fix things like that.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2398) Improve tests to work easier from
IDEs
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857791#action_12857791 ]
Robert Muir commented on LUCENE-2398:
-------------------------------------
I checked into this "lucene.common.dir", its only used currently in two places:
1. a couple benchmark tests use it to create some .alg files, for example TestQualityRun
{code}
private static String getReuters578LinesFile() {
return System.getProperty("lucene.common.dir").replace('\\','/') +
"/contrib/benchmark/src/test/org/apache/lucene/benchmark/quality/reuters.578.lines.txt.bz2";
}
{code}
2. the memory index test uses it as a base to find files on your hard drive to index.
I think this is similar to LUCENE-1756, and needs to also be fixed.
If we could improve these tests in this way, we could remove this lucene.common.dir alltogether and simplify the build system, too.
> Improve tests to work easier from IDEs
> --------------------------------------
>
> Key: LUCENE-2398
> URL: https://issues.apache.org/jira/browse/LUCENE-2398
> Project: Lucene - Java
> Issue Type: Test
> Reporter: Robert Muir
> Priority: Minor
> Attachments: LUCENE-2398.patch
>
>
> As reported by Paolo Castagna on the mailing lists, some tests fail when you run them from eclipse.
> Some of the failures he reports are actually code problems such as base test classes not being
> abstract when they should be... we should fix things like that.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2398) Improve tests to work easier from
IDEs
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2398:
--------------------------------
Attachment: LUCENE-2398.patch
Attached is an updated patch, with a new test for MemoryIndex.
Instead of looking for stuff on your hard drive, it creates some randomish documents using a selection of strings that will match the test queries, combined with some random unicode strings ala TestStressIndexing2.
This removes the use of lucene.common.dir here, so now moving on to the benchmark tests.
> Improve tests to work easier from IDEs
> --------------------------------------
>
> Key: LUCENE-2398
> URL: https://issues.apache.org/jira/browse/LUCENE-2398
> Project: Lucene - Java
> Issue Type: Test
> Reporter: Robert Muir
> Priority: Minor
> Attachments: LUCENE-2398.patch, LUCENE-2398.patch
>
>
> As reported by Paolo Castagna on the mailing lists, some tests fail when you run them from eclipse.
> Some of the failures he reports are actually code problems such as base test classes not being
> abstract when they should be... we should fix things like that.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org