You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@knox.apache.org by ha...@apache.org on 2026/07/01 19:40:47 UTC
(knox) branch master updated: KNOX-3371: Fix broken error message on login page (#1290)
This is an automated email from the ASF dual-hosted git repository.
hanicz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/knox.git
The following commit(s) were added to refs/heads/master by this push:
new 39a168a95 KNOX-3371: Fix broken error message on login page (#1290)
39a168a95 is described below
commit 39a168a95793093862fca77ad449523b8f4cdba6
Author: hanicz <ha...@users.noreply.github.com>
AuthorDate: Wed Jul 1 21:40:41 2026 +0200
KNOX-3371: Fix broken error message on login page (#1290)
---
.../applications/knoxauth/app/js/knoxauth.js | 7 ++++---
.../resources/applications/knoxauth/app/login.html | 7 ++++---
.../applications/knoxauth/app/styles/knox.css | 22 ++++++++++++++++++++++
3 files changed, 30 insertions(+), 6 deletions(-)
diff --git a/gateway-applications/src/main/resources/applications/knoxauth/app/js/knoxauth.js b/gateway-applications/src/main/resources/applications/knoxauth/app/js/knoxauth.js
index 50379c68d..4f91c2fca 100644
--- a/gateway-applications/src/main/resources/applications/knoxauth/app/js/knoxauth.js
+++ b/gateway-applications/src/main/resources/applications/knoxauth/app/js/knoxauth.js
@@ -86,14 +86,15 @@ var login = function() {
}
redirect(redirectUrl);
} else {
- $('#errorBox').show();
- $('#signInLoading').css('visibility', 'hidden');
- $('#signIn').removeAttr('disabled');
if (request.status == 401) {
$('#errorBox .errorMsg').text("The username or password you entered is incorrect.");
} else {
$('#errorBox .errorMsg').text("Response from " + request.responseURL + " - " + request.status + ": " + request.statusText);
}
+ $('#errorBox').show();
+ $('#signInLoading').css('visibility', 'hidden');
+ $('#signIn').removeAttr('disabled');
+ $(window).trigger('resize');
}
}
};
diff --git a/gateway-applications/src/main/resources/applications/knoxauth/app/login.html b/gateway-applications/src/main/resources/applications/knoxauth/app/login.html
index 0e938b0b5..8c69ec9c2 100644
--- a/gateway-applications/src/main/resources/applications/knoxauth/app/login.html
+++ b/gateway-applications/src/main/resources/applications/knoxauth/app/login.html
@@ -102,9 +102,10 @@
<label><i class="bi bi-lock"></i> Password:</label>
<input type="password" name="password" id="password" tabindex="2" autocomplete="off" onkeypress=keypressed(event)>
</div>
- <span id="errorBox" class="help-inline" style="color:white;display:none;"><span class="errorMsg"></span>
- <i class="bi bi-exclamation-triangle" style="color:#ae2817;"></i>
- </span>
+ <div id="errorBox" style="display:none;" role="alert">
+ <i class="bi bi-exclamation-triangle" aria-hidden="true"></i>
+ <span class="errorMsg"></span>
+ </div>
<button type="button" class="btn btn-primary w-100" id="signIn" tabindex="4" onkeypress="keypressed(event)" onclick="login();" style="position: relative; text-align: center;">
<span>Sign In</span>
<i id="signInLoading" class="bi bi-arrow-repeat icon-sign-in"></i>
diff --git a/gateway-applications/src/main/resources/applications/knoxauth/app/styles/knox.css b/gateway-applications/src/main/resources/applications/knoxauth/app/styles/knox.css
index a8fb9ad55..ba3873571 100644
--- a/gateway-applications/src/main/resources/applications/knoxauth/app/styles/knox.css
+++ b/gateway-applications/src/main/resources/applications/knoxauth/app/styles/knox.css
@@ -1732,6 +1732,28 @@ body.login {
box-shadow: none !important;
outline: none !important;
}
+.login #errorBox {
+ margin-top: 12px;
+ padding: 10px 12px;
+ background-color: rgba(174, 40, 23, 0.15);
+ border: 1px solid #ae2817;
+ border-radius: 3px;
+ color: #fff;
+ font-size: 13px;
+ line-height: 1.4;
+ word-wrap: break-word;
+ overflow-wrap: break-word;
+ box-sizing: border-box;
+ width: 100%;
+}
+.login #errorBox i {
+ color: #ae2817;
+ margin-right: 8px;
+ vertical-align: text-top;
+}
+.login #errorBox .errorMsg {
+ display: inline;
+}
.label-yellow{
background-color: #f3a139;
}