[jira] [Commented] (SPARK-4294) The same function should have the same realization.

["Apache Spark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-4294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201728#comment-14201728 ] 

Apache Spark commented on SPARK-4294:
-------------------------------------

User 'watermen' has created a pull request for this issue:
https://github.com/apache/spark/pull/3151

> The same function should have the same realization.
> ---------------------------------------------------
>
>                 Key: SPARK-4294
>                 URL: https://issues.apache.org/jira/browse/SPARK-4294
>             Project: Spark
>          Issue Type: Improvement
>          Components: Streaming
>    Affects Versions: 1.1.0
>            Reporter: Yadong Qi
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> In class TransformedDStream:
> require(parents.length > 0, "List of DStreams to transform is empty")
> require(parents.map(_.ssc).distinct.size == 1, "Some of the DStreams have different contexts")
> require(parents.map(_.slideDuration).distinct.size == 1,
>     "Some of the DStreams have different slide durations")
> In class UnionDStream:
>   if (parents.length == 0) {
>     throw new IllegalArgumentException("Empty array of parents")
>   }
>   if (parents.map(_.ssc).distinct.size > 1) {
>     throw new IllegalArgumentException("Array of parents have different StreamingContexts")
>   }
>   if (parents.map(_.slideDuration).distinct.size > 1) {
>     throw new IllegalArgumentException("Array of parents have different slide times")
>   }
> The function is the same, but the realization is not. I think they shoule be the same.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org