[GitHub] spark pull request #21581: [SPARK-24574][SQL] array_contains, array_position...

[ueshin <gi...@git.apache.org>]

Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21581#discussion_r196633968
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
    @@ -571,6 +571,10 @@ class DataFrameFunctionsSuite extends QueryTest with SharedSQLContext {
           df.selectExpr("array_contains(a, 1)"),
           Seq(Row(true), Row(false))
         )
    +    checkAnswer(
    +      df.select(array_contains(df("a"), df("c"))),
    +      Seq(Row(true), Row(false))
    +    )
    --- End diff --
    
    Can you add another test to use `selectExpr`, e.g., `df.selectExpr("array_contains(a, c)")`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org