You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by GitBox <gi...@apache.org> on 2021/06/28 11:13:31 UTC
[GitHub] [curator] eolivelli opened a new pull request #386: Upgrade ZK to 3.6.3
eolivelli opened a new pull request #386:
URL: https://github.com/apache/curator/pull/386
It looks like upgrading to ZK 3.6.3 is not that easy as for 3.6.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] virajjasani commented on pull request #386: Upgrade ZK to 3.6.3
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #386:
URL: https://github.com/apache/curator/pull/386#issuecomment-872822396
Thanks @eolivelli.
Build failure:
```
The command "eval mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V " failed
```
Is this relevant or some other known issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] eolivelli edited a comment on pull request #386: Upgrade ZK to 3.6.3
Posted by GitBox <gi...@apache.org>.
eolivelli edited a comment on pull request #386:
URL: https://github.com/apache/curator/pull/386#issuecomment-872989378
This patch is still a draft, because some tests are still failing
There is some behaviour changes in ZK 3.6.3 and we have to understand all the failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] madrob commented on a change in pull request #386: Upgrade ZK to 3.6.3
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #386:
URL: https://github.com/apache/curator/pull/386#discussion_r659828343
##########
File path: pom.xml
##########
@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="UTF-8"?><!--
+e?xml version="1.0" encoding="UTF-8"?><!--
Review comment:
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] eolivelli commented on pull request #386: Upgrade ZK to 3.6.3
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #386:
URL: https://github.com/apache/curator/pull/386#issuecomment-872989378
This patch is still a draft, because some tests are still failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] eolivelli merged pull request #386: CURATOR-588 Upgrade ZooKeeper to 3.6.3
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #386:
URL: https://github.com/apache/curator/pull/386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] eolivelli commented on a change in pull request #386: CURATOR-588 Upgrade ZooKeeper to 3.6.3
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #386:
URL: https://github.com/apache/curator/pull/386#discussion_r663871193
##########
File path: curator-framework/src/test/java/org/apache/curator/framework/imps/TestFrameworkEdges.java
##########
@@ -670,9 +670,13 @@ public void testFailure() throws Exception
client.checkExists().forPath("/hey");
fail();
}
+ catch ( KeeperException.SessionExpiredException e )
+ {
+ // correct, this happens on ZK 3.6.3+
Review comment:
I really do not know why this is happening.
I have looked thru ZK 3.6.3 release notes and I haven't found anything that may be releated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun commented on a change in pull request #386: CURATOR-588 Upgrade ZooKeeper to 3.6.3
Posted by GitBox <gi...@apache.org>.
tisonkun commented on a change in pull request #386:
URL: https://github.com/apache/curator/pull/386#discussion_r663844351
##########
File path: curator-framework/src/test/java/org/apache/curator/framework/imps/TestFrameworkEdges.java
##########
@@ -670,9 +670,13 @@ public void testFailure() throws Exception
client.checkExists().forPath("/hey");
fail();
}
+ catch ( KeeperException.SessionExpiredException e )
+ {
+ // correct, this happens on ZK 3.6.3+
Review comment:
Why? Shall we setup a link to the reason?
It is a bit weird a patch version bump cause behavior changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] eolivelli commented on a change in pull request #386: CURATOR-588 Upgrade ZooKeeper to 3.6.3
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #386:
URL: https://github.com/apache/curator/pull/386#discussion_r663871193
##########
File path: curator-framework/src/test/java/org/apache/curator/framework/imps/TestFrameworkEdges.java
##########
@@ -670,9 +670,13 @@ public void testFailure() throws Exception
client.checkExists().forPath("/hey");
fail();
}
+ catch ( KeeperException.SessionExpiredException e )
+ {
+ // correct, this happens on ZK 3.6.3+
Review comment:
I really do not know why this is happening.
I have looked thru ZK 3.6.3 release notes and I haven't found anything that may be releated.
##########
File path: curator-framework/src/test/java/org/apache/curator/framework/imps/TestFrameworkEdges.java
##########
@@ -670,9 +670,13 @@ public void testFailure() throws Exception
client.checkExists().forPath("/hey");
fail();
}
+ catch ( KeeperException.SessionExpiredException e )
+ {
+ // correct, this happens on ZK 3.6.3+
Review comment:
probably Session Expiration is happening earlier with 3.6.3
with 3.6.2 we still see a ConnectionLoss, that usually becomes a SessionExpired when the client is able to connect again and the ZK server already expired it on the server side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] eolivelli merged pull request #386: CURATOR-588 Upgrade ZooKeeper to 3.6.3
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #386:
URL: https://github.com/apache/curator/pull/386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] eolivelli commented on pull request #386: Upgrade ZK to 3.6.3
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #386:
URL: https://github.com/apache/curator/pull/386#issuecomment-873991697
@cammckenzie I have fixed the problem for zk35 compatibility test.
The weird behaviour is about a ConnectionLoss vs SessionExpired that happens in a test from 3.6.3 onwards
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun commented on a change in pull request #386: CURATOR-588 Upgrade ZooKeeper to 3.6.3
Posted by GitBox <gi...@apache.org>.
tisonkun commented on a change in pull request #386:
URL: https://github.com/apache/curator/pull/386#discussion_r663844351
##########
File path: curator-framework/src/test/java/org/apache/curator/framework/imps/TestFrameworkEdges.java
##########
@@ -670,9 +670,13 @@ public void testFailure() throws Exception
client.checkExists().forPath("/hey");
fail();
}
+ catch ( KeeperException.SessionExpiredException e )
+ {
+ // correct, this happens on ZK 3.6.3+
Review comment:
Why? Shall we setup a link to the reason?
It is a bit weird a patch version bump cause behavior changes.
##########
File path: curator-framework/src/test/java/org/apache/curator/framework/imps/TestFrameworkEdges.java
##########
@@ -670,9 +670,13 @@ public void testFailure() throws Exception
client.checkExists().forPath("/hey");
fail();
}
+ catch ( KeeperException.SessionExpiredException e )
+ {
+ // correct, this happens on ZK 3.6.3+
Review comment:
Why? Shall we add a link to the reason?
It is a bit weird a patch version bump cause behavior changes.
##########
File path: curator-framework/src/test/java/org/apache/curator/framework/imps/TestFrameworkEdges.java
##########
@@ -670,9 +670,13 @@ public void testFailure() throws Exception
client.checkExists().forPath("/hey");
fail();
}
+ catch ( KeeperException.SessionExpiredException e )
+ {
+ // correct, this happens on ZK 3.6.3+
Review comment:
Fine. It is not a blocker for client library such as Curator, but is interesting...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun commented on a change in pull request #386: CURATOR-588 Upgrade ZooKeeper to 3.6.3
Posted by GitBox <gi...@apache.org>.
tisonkun commented on a change in pull request #386:
URL: https://github.com/apache/curator/pull/386#discussion_r663876941
##########
File path: curator-framework/src/test/java/org/apache/curator/framework/imps/TestFrameworkEdges.java
##########
@@ -670,9 +670,13 @@ public void testFailure() throws Exception
client.checkExists().forPath("/hey");
fail();
}
+ catch ( KeeperException.SessionExpiredException e )
+ {
+ // correct, this happens on ZK 3.6.3+
Review comment:
Fine. It is not a blocker for client library such as Curator, but is interesting...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] madrob commented on a change in pull request #386: Upgrade ZK to 3.6.3
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #386:
URL: https://github.com/apache/curator/pull/386#discussion_r659828343
##########
File path: pom.xml
##########
@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="UTF-8"?><!--
+e?xml version="1.0" encoding="UTF-8"?><!--
Review comment:
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] eolivelli commented on a change in pull request #386: CURATOR-588 Upgrade ZooKeeper to 3.6.3
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #386:
URL: https://github.com/apache/curator/pull/386#discussion_r663880092
##########
File path: curator-framework/src/test/java/org/apache/curator/framework/imps/TestFrameworkEdges.java
##########
@@ -670,9 +670,13 @@ public void testFailure() throws Exception
client.checkExists().forPath("/hey");
fail();
}
+ catch ( KeeperException.SessionExpiredException e )
+ {
+ // correct, this happens on ZK 3.6.3+
Review comment:
probably Session Expiration is happening earlier with 3.6.3
with 3.6.2 we still see a ConnectionLoss, that usually becomes a SessionExpired when the client is able to connect again and the ZK server already expired it on the server side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] eolivelli commented on pull request #386: Upgrade ZK to 3.6.3
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #386:
URL: https://github.com/apache/curator/pull/386#issuecomment-873991697
@cammckenzie I have fixed the problem for zk35 compatibility test.
The weird behaviour is about a ConnectionLoss vs SessionExpired that happens in a test from 3.6.3 onwards
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun commented on a change in pull request #386: CURATOR-588 Upgrade ZooKeeper to 3.6.3
Posted by GitBox <gi...@apache.org>.
tisonkun commented on a change in pull request #386:
URL: https://github.com/apache/curator/pull/386#discussion_r663844351
##########
File path: curator-framework/src/test/java/org/apache/curator/framework/imps/TestFrameworkEdges.java
##########
@@ -670,9 +670,13 @@ public void testFailure() throws Exception
client.checkExists().forPath("/hey");
fail();
}
+ catch ( KeeperException.SessionExpiredException e )
+ {
+ // correct, this happens on ZK 3.6.3+
Review comment:
Why? Shall we add a link to the reason?
It is a bit weird a patch version bump cause behavior changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] eolivelli commented on a change in pull request #386: Upgrade ZK to 3.6.3
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #386:
URL: https://github.com/apache/curator/pull/386#discussion_r663003867
##########
File path: pom.xml
##########
@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="UTF-8"?><!--
+e?xml version="1.0" encoding="UTF-8"?><!--
Review comment:
it was not intended, thanks @madrob
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org