[jira] [Commented] (IGNITE-187) GridManager should be able to add custom attributes

["Yakov Zhdanov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350887#comment-14350887 ] 

Yakov Zhdanov commented on IGNITE-187:
--------------------------------------

Alex, sometimes StartNodes plan fails with the following:
{code}
[17:12:12,225][INFO ][main][IgniteProjectionStartStopRestartSelfTest] >>> Stopping test: testStartFiveNodesInTwoCalls in 5043 ms <<<
[17:12:12] (wrn) Ignoring stopping grid instance that was already stopped or never started: null
------- Stderr: -------
[17:12:11,321][ERROR][main][IgniteKernal] Got exception while starting (will rollback startup routine).
java.util.ConcurrentModificationException
    at java.util.Hashtable$Enumerator.next(Hashtable.java:1167)
    at org.apache.ignite.internal.util.lang.GridFunc$103.hasNextX(GridFunc.java:4217)
    at org.apache.ignite.internal.util.lang.GridIteratorAdapter.hasNext(GridIteratorAdapter.java:45)
    at org.apache.ignite.internal.IgniteKernal.fillNodeAttributes(IgniteKernal.java:1121)
    at org.apache.ignite.internal.IgniteKernal.start(IgniteKernal.java:676)
    at org.apache.ignite.internal.IgnitionEx$IgniteNamedInstance.start0(IgnitionEx.java:1410)
    at org.apache.ignite.internal.IgnitionEx$IgniteNamedInstance.start(IgnitionEx.java:1274)
    at org.apache.ignite.internal.IgnitionEx.start0(IgnitionEx.java:856)
    at org.apache.ignite.internal.IgnitionEx.start(IgnitionEx.java:756)
    at org.apache.ignite.internal.IgnitionEx.start(IgnitionEx.java:690)
    at org.apache.ignite.internal.IgnitionEx.start(IgnitionEx.java:644)
    at org.apache.ignite.internal.IgnitionEx.start(IgnitionEx.java:505)
    at org.apache.ignite.internal.IgnitionEx.start(IgnitionEx.java:475)
    at org.apache.ignite.Ignition.start(Ignition.java:313)
    at org.apache.ignite.internal.IgniteProjectionStartStopRestartSelfTest.beforeTest(IgniteProjectionStartStopRestartSelfTest.java:123)
    at org.apache.ignite.testframework.junits.GridAbstractTest.setUp(GridAbstractTest.java:480)
    at org.apache.ignite.testframework.junits.common.GridCommonAbstractTest.setUp(GridCommonAbstractTest.java:340)
    at junit.framework.TestCase.runBare(TestCase.java:139)
    at junit.framework.TestResult$1.protect(TestResult.java:122)
    at junit.framework.TestResult.runProtected(TestResult.java:142)
    at junit.framework.TestResult.run(TestResult.java:125)
    at junit.framework.TestCase.run(TestCase.java:129)
    at junit.framework.TestSuite.runTest(TestSuite.java:255)
    at junit.framework.TestSuite.run(TestSuite.java:250)
    at junit.framework.TestSuite.runTest(TestSuite.java:255)
    at junit.framework.TestSuite.run(TestSuite.java:250)
{code}

It seems {{System.getProperties()}} should be iterated over inside sync block. Please find all the places and fix.

> GridManager should be able to add custom attributes
> ---------------------------------------------------
>
>                 Key: IGNITE-187
>                 URL: https://issues.apache.org/jira/browse/IGNITE-187
>             Project: Ignite
>          Issue Type: Task
>          Components: general
>    Affects Versions: sprint-1
>            Reporter: Alexey Kuznetsov
>            Assignee: Alexey Kuznetsov
>             Fix For: sprint-2
>
>         Attachments: 0001-IGNITE-187-Refactoring-of-node-attributes.patch
>
>
> GridKernal.createNodeAttributes() will be much shorter
> I am thinking of special methods on KernalContext like addNodeAttr() and sealNodeAttrs(). First adds attributes to a map. Second, being called only from disco manager, makes new adds impossible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)