You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by mw...@apache.org on 2020/07/03 12:25:59 UTC

[beam] branch master updated: [BEAM-10403] Removed asterisk from default file prefix in Snowflake write

This is an automated email from the ASF dual-hosted git repository.

mwalenia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new ae8da14  [BEAM-10403] Removed asterisk from default file prefix in Snowflake write
     new de41e60  Merge pull request #12171 from PolideaInternal/BEAM-10403-fix-prefix
ae8da14 is described below

commit ae8da14bf1c52996d20d44d7bf69981623414c1d
Author: Kasia Kucharczyk <ka...@polidea.com>
AuthorDate: Fri Jul 3 11:26:34 2020 +0200

    [BEAM-10403] Removed asterisk from default file prefix in Snowflake write
---
 .../src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java | 2 +-
 .../io/snowflake/test/unit/write/QueryDispositionLocationTest.java  | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java b/sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java
index 4895e4e..1325864 100644
--- a/sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java
+++ b/sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java
@@ -221,7 +221,7 @@ public class SnowflakeIO {
    */
   public static <T> Write<T> write() {
     return new AutoValue_SnowflakeIO_Write.Builder<T>()
-        .setFileNameTemplate("output*")
+        .setFileNameTemplate("output")
         .setWriteDisposition(WriteDisposition.APPEND)
         .build();
   }
diff --git a/sdks/java/io/snowflake/src/test/java/org/apache/beam/sdk/io/snowflake/test/unit/write/QueryDispositionLocationTest.java b/sdks/java/io/snowflake/src/test/java/org/apache/beam/sdk/io/snowflake/test/unit/write/QueryDispositionLocationTest.java
index 593f026..a9cbc44 100644
--- a/sdks/java/io/snowflake/src/test/java/org/apache/beam/sdk/io/snowflake/test/unit/write/QueryDispositionLocationTest.java
+++ b/sdks/java/io/snowflake/src/test/java/org/apache/beam/sdk/io/snowflake/test/unit/write/QueryDispositionLocationTest.java
@@ -97,7 +97,7 @@ public class QueryDispositionLocationTest {
                 .withStagingBucketName(options.getStagingBucketName())
                 .withStorageIntegrationName(options.getStorageIntegrationName())
                 .withUserDataMapper(TestUtils.getLongCsvMapper())
-                .withFileNameTemplate("output*")
+                .withFileNameTemplate("output")
                 .withWriteDisposition(WriteDisposition.TRUNCATE)
                 .withSnowflakeService(snowflakeService));
 
@@ -126,7 +126,7 @@ public class QueryDispositionLocationTest {
                 .withStagingBucketName(options.getStagingBucketName())
                 .withStorageIntegrationName(options.getStorageIntegrationName())
                 .withUserDataMapper(TestUtils.getLongCsvMapper())
-                .withFileNameTemplate("output*")
+                .withFileNameTemplate("output")
                 .withWriteDisposition(WriteDisposition.EMPTY)
                 .withSnowflakeService(snowflakeService));
 
@@ -146,7 +146,7 @@ public class QueryDispositionLocationTest {
                 .withTable(FAKE_TABLE)
                 .withStagingBucketName(options.getStagingBucketName())
                 .withStorageIntegrationName(options.getStorageIntegrationName())
-                .withFileNameTemplate("output*")
+                .withFileNameTemplate("output")
                 .withUserDataMapper(TestUtils.getLongCsvMapper())
                 .withWriteDisposition(WriteDisposition.EMPTY)
                 .withSnowflakeService(snowflakeService));