You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by rx...@apache.org on 2014/07/31 00:04:36 UTC
git commit: SPARK-2749 [BUILD]. Spark SQL Java tests aren't compiling
in Jenkins' Maven builds; missing junit:junit dep
Repository: spark
Updated Branches:
refs/heads/master 2f4b17056 -> 6ab96a6fd
SPARK-2749 [BUILD]. Spark SQL Java tests aren't compiling in Jenkins' Maven builds; missing junit:junit dep
The Maven-based builds in the build matrix have been failing for a few days:
https://amplab.cs.berkeley.edu/jenkins/view/Spark/
On inspection, it looks like the Spark SQL Java tests don't compile:
https://amplab.cs.berkeley.edu/jenkins/view/Spark/job/Spark-Master-Maven-pre-YARN/hadoop.version=1.0.4,label=centos/244/consoleFull
I confirmed it by repeating the command vs master:
`mvn -Dhadoop.version=1.0.4 -Dlabel=centos -DskipTests clean package`
The problem is that this module doesn't depend on JUnit. In fact, none of the modules do, but `com.novocode:junit-interface` (the SBT-JUnit bridge) pulls it in, in most places. However this module doesn't depend on `com.novocode:junit-interface`
Adding the `junit:junit` dependency fixes the compile problem. In fact, the other modules with Java tests should probably depend on it explicitly instead of happening to get it via `com.novocode:junit-interface`, since that is a bit SBT/Scala-specific (and I am not even sure it's needed).
Author: Sean Owen <sr...@gmail.com>
Closes #1660 from srowen/SPARK-2749 and squashes the following commits:
858ff7c [Sean Owen] Add explicit junit dep to other modules with Java tests for robustness
9636794 [Sean Owen] Add junit dep so that Spark SQL Java tests compile
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/6ab96a6f
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/6ab96a6f
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/6ab96a6f
Branch: refs/heads/master
Commit: 6ab96a6fd0db7731c8c5d6478d9e28b619581687
Parents: 2f4b170
Author: Sean Owen <sr...@gmail.com>
Authored: Wed Jul 30 15:04:33 2014 -0700
Committer: Reynold Xin <rx...@apache.org>
Committed: Wed Jul 30 15:04:33 2014 -0700
----------------------------------------------------------------------
core/pom.xml | 5 +++++
external/flume/pom.xml | 5 +++++
external/kafka/pom.xml | 5 +++++
external/mqtt/pom.xml | 5 +++++
external/twitter/pom.xml | 5 +++++
external/zeromq/pom.xml | 5 +++++
extras/java8-tests/pom.xml | 5 +++++
mllib/pom.xml | 5 +++++
sql/core/pom.xml | 5 +++++
streaming/pom.xml | 5 +++++
10 files changed, 50 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/6ab96a6f/core/pom.xml
----------------------------------------------------------------------
diff --git a/core/pom.xml b/core/pom.xml
index 4f06109..04d4b9c 100644
--- a/core/pom.xml
+++ b/core/pom.xml
@@ -263,6 +263,11 @@
<scope>test</scope>
</dependency>
<dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
<groupId>com.novocode</groupId>
<artifactId>junit-interface</artifactId>
<scope>test</scope>
http://git-wip-us.apache.org/repos/asf/spark/blob/6ab96a6f/external/flume/pom.xml
----------------------------------------------------------------------
diff --git a/external/flume/pom.xml b/external/flume/pom.xml
index 9f680b2..c532705 100644
--- a/external/flume/pom.xml
+++ b/external/flume/pom.xml
@@ -73,6 +73,11 @@
<scope>test</scope>
</dependency>
<dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
<groupId>com.novocode</groupId>
<artifactId>junit-interface</artifactId>
<scope>test</scope>
http://git-wip-us.apache.org/repos/asf/spark/blob/6ab96a6f/external/kafka/pom.xml
----------------------------------------------------------------------
diff --git a/external/kafka/pom.xml b/external/kafka/pom.xml
index 25a5c0a..daf0336 100644
--- a/external/kafka/pom.xml
+++ b/external/kafka/pom.xml
@@ -81,6 +81,11 @@
<scope>test</scope>
</dependency>
<dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
<groupId>com.novocode</groupId>
<artifactId>junit-interface</artifactId>
<scope>test</scope>
http://git-wip-us.apache.org/repos/asf/spark/blob/6ab96a6f/external/mqtt/pom.xml
----------------------------------------------------------------------
diff --git a/external/mqtt/pom.xml b/external/mqtt/pom.xml
index f31ed65..dc48a08 100644
--- a/external/mqtt/pom.xml
+++ b/external/mqtt/pom.xml
@@ -68,6 +68,11 @@
<scope>test</scope>
</dependency>
<dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
<groupId>com.novocode</groupId>
<artifactId>junit-interface</artifactId>
<scope>test</scope>
http://git-wip-us.apache.org/repos/asf/spark/blob/6ab96a6f/external/twitter/pom.xml
----------------------------------------------------------------------
diff --git a/external/twitter/pom.xml b/external/twitter/pom.xml
index 56bb24c..b93ad01 100644
--- a/external/twitter/pom.xml
+++ b/external/twitter/pom.xml
@@ -63,6 +63,11 @@
<scope>test</scope>
</dependency>
<dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
<groupId>com.novocode</groupId>
<artifactId>junit-interface</artifactId>
<scope>test</scope>
http://git-wip-us.apache.org/repos/asf/spark/blob/6ab96a6f/external/zeromq/pom.xml
----------------------------------------------------------------------
diff --git a/external/zeromq/pom.xml b/external/zeromq/pom.xml
index 54b0242..22c1fff 100644
--- a/external/zeromq/pom.xml
+++ b/external/zeromq/pom.xml
@@ -63,6 +63,11 @@
<scope>test</scope>
</dependency>
<dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
<groupId>com.novocode</groupId>
<artifactId>junit-interface</artifactId>
<scope>test</scope>
http://git-wip-us.apache.org/repos/asf/spark/blob/6ab96a6f/extras/java8-tests/pom.xml
----------------------------------------------------------------------
diff --git a/extras/java8-tests/pom.xml b/extras/java8-tests/pom.xml
index 3eade41..5308bb4 100644
--- a/extras/java8-tests/pom.xml
+++ b/extras/java8-tests/pom.xml
@@ -51,6 +51,11 @@
<type>test-jar</type>
</dependency>
<dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
<groupId>com.novocode</groupId>
<artifactId>junit-interface</artifactId>
<scope>test</scope>
http://git-wip-us.apache.org/repos/asf/spark/blob/6ab96a6f/mllib/pom.xml
----------------------------------------------------------------------
diff --git a/mllib/pom.xml b/mllib/pom.xml
index f27cf52..cb0fa7b 100644
--- a/mllib/pom.xml
+++ b/mllib/pom.xml
@@ -73,6 +73,11 @@
<scope>test</scope>
</dependency>
<dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
<groupId>com.novocode</groupId>
<artifactId>junit-interface</artifactId>
<scope>test</scope>
http://git-wip-us.apache.org/repos/asf/spark/blob/6ab96a6f/sql/core/pom.xml
----------------------------------------------------------------------
diff --git a/sql/core/pom.xml b/sql/core/pom.xml
index 3a038a2..c8016e4 100644
--- a/sql/core/pom.xml
+++ b/sql/core/pom.xml
@@ -69,6 +69,11 @@
<version>2.3.0</version>
</dependency>
<dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
<groupId>org.scalatest</groupId>
<artifactId>scalatest_${scala.binary.version}</artifactId>
<scope>test</scope>
http://git-wip-us.apache.org/repos/asf/spark/blob/6ab96a6f/streaming/pom.xml
----------------------------------------------------------------------
diff --git a/streaming/pom.xml b/streaming/pom.xml
index b99f306..1072f74 100644
--- a/streaming/pom.xml
+++ b/streaming/pom.xml
@@ -59,6 +59,11 @@
<scope>test</scope>
</dependency>
<dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
<groupId>com.novocode</groupId>
<artifactId>junit-interface</artifactId>
<scope>test</scope>