You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/05/31 18:25:25 UTC

[GitHub] [incubator-iceberg] TGooch44 commented on a change in pull request #196: Backporting case-sensitivity flag to expression module

TGooch44 commented on a change in pull request #196: Backporting case-sensitivity flag to expression module
URL: https://github.com/apache/incubator-iceberg/pull/196#discussion_r289503003
 
 

 ##########
 File path: python/iceberg/api/expressions/inclusive_metrics_evaluator.py
 ##########
 @@ -52,13 +53,13 @@ def __init__(self, expr, schema, struct):
         self.struct = struct
 
     def eval(self, file):
-        if file.record_count <= 0:
+        if file.record_count() <= 0:
 
 Review comment:
   both items were/are bugs, that were fixed between the initial commit and when I started the case-sensitivity backport

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org