You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Aljoscha Krettek (Jira)" <ji...@apache.org> on 2019/09/19 15:10:00 UTC

[jira] [Commented] (FLINK-14130) Remove ClusterClient.run() methods

    [ https://issues.apache.org/jira/browse/FLINK-14130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933489#comment-16933489 ] 

Aljoscha Krettek commented on FLINK-14130:
------------------------------------------

cc [~Tison] This has relations with some of the other issues.

 

cc [~trohrmann@apache.org], [~Zentol]

> Remove ClusterClient.run() methods
> ----------------------------------
>
>                 Key: FLINK-14130
>                 URL: https://issues.apache.org/jira/browse/FLINK-14130
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Client / Job Submission
>            Reporter: Aljoscha Krettek
>            Priority: Major
>
> {{ClusterClient}} is an internal interface of the {{flink-clients}} package. It should only be concerned with submitting {{JobGraphs}} to a cluster, which is what {{submitJob()}} does. 
> The {{run()}} methods are concerned with unpacking programs or job-with-jars and at the end use {{submitJob()}} in some way, they should reside in some other component. The only valid remaining run method is {{run(PackagedProgram prog, int parallelism)}}, this could be in {{PackagedProgramUtils}}. The other {{run()}} methods are actually only used in one test: {{ClientTest.shouldSubmitToJobClient()}}. I don't think that test is valid anymore, it evolved for a very long time and now doesn't test what it was supposed to test once.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)