You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/27 14:39:09 UTC
[GitHub] [incubator-nuttx-apps] fjpanag opened a new pull request, #1328: Fixed non-UTF8 characters.
fjpanag opened a new pull request, #1328:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1328
## Summary
Fixed several non-UTF8 characters throughout the source code.
See also [here](https://github.com/apache/incubator-nuttx/pull/7201).
## Impact
N/A
## Testing
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] fjpanag commented on a diff in pull request #1328: Fixed non-UTF8 characters.
Posted by GitBox <gi...@apache.org>.
fjpanag commented on code in PR #1328:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1328#discussion_r983581092
##########
netutils/thttpd/tdate_parse.c:
##########
@@ -93,11 +93,14 @@ static int strlong_compare(const void *v1, const void *v2)
#ifdef HAVE_DAY_OF_WEEK /* Day of week not yet supported by NuttX */
static int strlong_search(char *str, struct strlong *tab, int n, long *lP)
Review Comment:
I didn't go through the code, so I don't know what `lP` means or what would be a more appropriate name.
Do you have a suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] fjpanag commented on pull request #1328: Fixed non-UTF8 characters.
Posted by GitBox <gi...@apache.org>.
fjpanag commented on PR #1328:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1328#issuecomment-1262074980
I fixed as much style issues as I could.
If someone has any recommendations on how to resolve any of the remaining, I would happy to apply the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] fjpanag commented on pull request #1328: Fixed non-UTF8 characters.
Posted by GitBox <gi...@apache.org>.
fjpanag commented on PR #1328:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1328#issuecomment-1260561527
> Hi @fjpanag could you please also fix the issue that was already in these files and were reported by our CI, they are old files, before CI/nxstyle and need to be fixed
Yes of course. I run out of time yesterday...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1328: Fixed non-UTF8 characters.
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1328:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1328#discussion_r983587885
##########
netutils/thttpd/tdate_parse.c:
##########
@@ -93,11 +93,14 @@ static int strlong_compare(const void *v1, const void *v2)
#ifdef HAVE_DAY_OF_WEEK /* Day of week not yet supported by NuttX */
static int strlong_search(char *str, struct strlong *tab, int n, long *lP)
Review Comment:
np. we can keep as is. Or just go to lower case `lp`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] fjpanag commented on a diff in pull request #1328: Fixed non-UTF8 characters.
Posted by GitBox <gi...@apache.org>.
fjpanag commented on code in PR #1328:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1328#discussion_r983578122
##########
netutils/thttpd/timers.c:
##########
@@ -293,12 +297,13 @@ void tmr_run(struct timeval *now)
{
next = tmr->next;
- /* Since the lists are sorted, as soon as we find a timer * that isn'tmr
- * ready yet, we can go on to the next list
+ /* Since the lists are sorted, as soon as we find a timer that
+ * isn't ready yet, we can go on to the next list.
*/
if (tmr->time.tv_sec > now->tv_sec ||
- (tmr->time.tv_sec == now->tv_sec && tmr->time.tv_usec > now->tv_usec))
+ (tmr->time.tv_sec == now->tv_sec &&
+ tmr->time.tv_usec > now->tv_usec))
Review Comment:
I got a warning for a long line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1328: Fixed non-UTF8 characters.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #1328:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] acassis commented on pull request #1328: Fixed non-UTF8 characters.
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #1328:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1328#issuecomment-1260152270
Hi @fjpanag could you please also fix the issue that was already in these files and were reported by our CI, they are old files, before CI/nxstyle and need to be fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1328: Fixed non-UTF8 characters.
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1328:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1328#discussion_r983573575
##########
netutils/thttpd/tdate_parse.c:
##########
@@ -93,11 +93,14 @@ static int strlong_compare(const void *v1, const void *v2)
#ifdef HAVE_DAY_OF_WEEK /* Day of week not yet supported by NuttX */
static int strlong_search(char *str, struct strlong *tab, int n, long *lP)
Review Comment:
maybe warning can be fixed?
##########
netutils/thttpd/timers.c:
##########
@@ -293,12 +297,13 @@ void tmr_run(struct timeval *now)
{
next = tmr->next;
- /* Since the lists are sorted, as soon as we find a timer * that isn'tmr
- * ready yet, we can go on to the next list
+ /* Since the lists are sorted, as soon as we find a timer that
+ * isn't ready yet, we can go on to the next list.
*/
if (tmr->time.tv_sec > now->tv_sec ||
- (tmr->time.tv_sec == now->tv_sec && tmr->time.tv_usec > now->tv_usec))
+ (tmr->time.tv_sec == now->tv_sec &&
+ tmr->time.tv_usec > now->tv_usec))
Review Comment:
what was an issue here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org