[GitHub] [fineract] palanisami opened a new pull request #569: FINERACT-689

[GitBox <gi...@apache.org>]

palanisami opened a new pull request #569: FINERACT-689
URL: https://github.com/apache/fineract/pull/569
 
 
   ## Description
   1) Go to Admin>Products and select either Fixed Deposit Products or Recurring Deposit Products and then click on Create Fixed Deposit Product/Recurring Deposit Product.
   
   2) Give all mandatory inputs and under 'Interest Rate Chart' provide 'Valid From Date' and then just submit it without adding interest rate.
   
   > Able to Submit and create FD/RD product without interest rate chart.
   
   Expected: Validation should be thrown 'Interest Rate is not added' , once submit button is hit. 
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Commit message starts with the issue number from https://issues.apache.org/jira/browse/FINERACT-689.
   
   - [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
   
   - [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
   
   - [ ] Integration tests have been created/updated for verifying the changes made.
   
   - [ ] All Integrations tests are passing with the new commits.
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services