You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2016/12/16 16:28:31 UTC
[Bug 60489] New: Add visio.ConnectsType class to ooxml-schemas
https://bz.apache.org/bugzilla/show_bug.cgi?id=60489
Bug ID: 60489
Summary: Add visio.ConnectsType class to ooxml-schemas
Product: POI
Version: 3.16-dev
Hardware: PC
Status: NEW
Severity: normal
Priority: P2
Component: XDGF
Assignee: dev@poi.apache.org
Reporter: tallison@mitre.org
Target Milestone: ---
Created attachment 34530
--> https://bz.apache.org/bugzilla/attachment.cgi?id=34530&action=edit
triggering file
On TIKA-2208, David Pilato shared a .vsdx that includes a class we aren't
including in our stripped down ooxml-schemas:
com.microsoft.schemas.office.visio.x2012.main.ConnectsType
Let's add that file to our unit tests to avoid ClassNotFoundException.
As a side note/question...I thought I remembered with xwpf, when a class wasn't
found, we logged it but didn't throw a CNFE...am I remembering this correctly?
If this is the case, do we need to modify our vsdx code to handle this?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 60489] Add visio.ConnectsType class to ooxml-schemas
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60489
Javen O'Neal <on...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS| |All
--- Comment #1 from Javen O'Neal <on...@apache.org> ---
If the full ooxml-schemas is used, is a CNFE thrown (making sure that the 2006
schemas are sufficient).
Just add a unit test that includes ConnectsType and it will be included in
poi-ooxml-schemas.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 60489] Add visio.ConnectsType class to ooxml-schemas
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60489
--- Comment #5 from Tim Allison <ta...@mitre.org> ---
Double, doh!
Needed to add @Test annotation to actually trigger the addition...
r1788288
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 60489] Add visio.ConnectsType class to ooxml-schemas
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60489
--- Comment #2 from Tim Allison <ta...@mitre.org> ---
Y, adding the file to our unit tests fixes the problem. Will commit shortly.
Thank you!
Larger question though...am I remembering incorrectly that we used to handle
missing beans via logging instead of allowing the CNFE? In short, does this
point to a need to modify our ooxml-visio parser...or do we carry on with the
current procedure...adding triggering files as people complain?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 60489] Add visio.ConnectsType class to ooxml-schemas
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60489
Tim Allison <ta...@mitre.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #4 from Tim Allison <ta...@mitre.org> ---
Doh...resolve
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 60489] Add visio.ConnectsType class to ooxml-schemas
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60489
--- Comment #3 from Tim Allison <ta...@mitre.org> ---
r1774638
If we need to modify our ooxml visio parser to log missing beans rather than
throwing a CNFE, let's open a separate issue.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org