[GitHub] [geode] gesterzhou opened pull request #3086: GEODE-6277: use await() instead of hard-coded sleep(3000) in the test

["gesterzhou (GitHub)" <gi...@apache.org>]

Thank you for submitting a contribution to Apache Geode.

@jhuynh1 

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3086 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on pull request #3086: GEODE-6277: use await() instead of hard-coded sleep(3000) in the test

["mcmellawatt (GitHub)" <gi...@apache.org>]

Couldn't you just do:

```await().until(() -> getRootRegion().getSubregion(name) == null || getRegionAttributes().getScope().isGlobal())```

and eliminate the asserts?  Just a bit less verbose I think, but its up to you.

[ Full content available at: https://github.com/apache/geode/pull/3086 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt closed pull request #3086: GEODE-6277: use await() instead of hard-coded sleep(3000) in the test

["mcmellawatt (GitHub)" <gi...@apache.org>]

[ pull request closed by mcmellawatt ]

[ Full content available at: https://github.com/apache/geode/pull/3086 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org