[GitHub] [incubator-heron] thinker0 commented on a change in pull request #3797: Upgrade protobuf to 3.16.1 CVE-2021-22569

[GitBox <gi...@apache.org>]

thinker0 commented on a change in pull request #3797:
URL: https://github.com/apache/incubator-heron/pull/3797#discussion_r834972513



##########
File path: heron/common/src/cpp/network/event_loop_impl.cpp
##########
@@ -18,6 +18,7 @@
  */
 
 #include "network/event_loop_impl.h"
+#include <signal.h>

Review comment:
       ```
   Execution platform: @local_config_platform//:host
   In file included from external/org_libevent_libevent/include/event.h:69:0,
                    from heron/common/src/cpp/network/regevent.h:27,
                    from heron/common/src/cpp/network/event_loop_impl.cpp:26:
   heron/common/src/cpp/network/event_loop_impl.cpp: In member function 'virtual void EventLoopImpl::loop()':
   heron/common/src/cpp/network/event_loop_impl.cpp:85:50: error: 'SIGTERM' was not declared in this scope
      struct event *term = evsignal_new(mDispatcher, SIGTERM, handleTerm, mDispatcher);
                                                     ^
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org