[GitHub] stevedlawrence commented on a change in pull request #155: Don't require binaryNumberRep for hexBinary

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #155: Don't require binaryNumberRep for hexBinary
URL: https://github.com/apache/incubator-daffodil/pull/155#discussion_r241200540
 
 

 ##########
 File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala
 ##########
 @@ -701,6 +704,7 @@ trait ElementBase
                   alignInBits, implicitAlignmentInBits, primType.name, this.knownEncodingName)
             }
             case Representation.Binary => primType match {
+              case PrimType.HexBinary => 8
 
 Review comment:
   I think the 8 here does nothing? This part of this val is just doing validation like making sure packed decimals are aligned. We don't have that restriction with hex binary since we allow hexbinary to be non-byte sized and non-byte aligned. So I think this can just be a no-op like the Float/Double/Booleans below it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services