[jira] [Commented] (CALCITE-3491) VolcanoPlanner.completeConversion() is bypassed by "if (true)"

["Stamatis Zampetakis (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972161#comment-16972161 ] 

Stamatis Zampetakis commented on CALCITE-3491:
----------------------------------------------

From the logs it seems that the method was never really used so it should be safe to remove it. However, I think that before doing so we should understand what is/was the purpose for writing it in the first place; obviously it is/was work in progress so it may consist in a missing feature of the planner.

> VolcanoPlanner.completeConversion() is bypassed by "if (true)"
> --------------------------------------------------------------
>
>                 Key: CALCITE-3491
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3491
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Xiening Dai
>            Priority: Major
>
> Not very clear about why we need VolcanoPlanner.completeConversion(). It's currently bypassed as below[1] -
>    if (true) {
>       return rel;
>     }
> If the method is not needed, we should just remove it.
> [1] https://github.com/apache/calcite/blob/f90e5d7b48848191c1a70e6c0f78eece93433806/core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java#L1096



--
This message was sent by Atlassian Jira
(v8.3.4#803005)