You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2017/04/02 10:36:47 UTC

[GitHub] spark pull request #17489: [SPARK-20166][SQL] Use XXX for ISO 8601 timezone ...

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17489#discussion_r109305593
  
    --- Diff: python/pyspark/sql/readwriter.py ---
    @@ -363,7 +363,7 @@ def csv(self, path, schema=None, sep=None, encoding=None, quote=None, escape=Non
             :param timestampFormat: sets the string that indicates a timestamp format. Custom date
                                     formats follow the formats at ``java.text.SimpleDateFormat``.
                                     This applies to timestamp type. If None is set, it uses the
    -                                default value, ``yyyy-MM-dd'T'HH:mm:ss.SSSZZ``.
    +                                default value, ``yyyy-MM-dd'T'HH:mm:ss.SSSXXX``.
    --- End diff --
    
    Yea, they look similar instances. However, it seems the doc states 
    
    > ... the timestamp of that moment in the current system time zone ...
    
    > ...  using the default timezone and the default locale, ...
    
    This probably is fine up to my knowledge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org