You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/01 09:58:27 UTC
[GitHub] [dubbo-go-pixiu] ztelur opened a new pull request #245: quick start and httpproxy
ztelur opened a new pull request #245:
URL: https://github.com/apache/dubbo-go-pixiu/pull/245
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
- modify readme.md to optimize quick start process
- use default httpclient in httpproxyfilter to avoid un-configurable-code
**Special notes for your reviewer**:
- add start.sh file to quick start samples for use
```
./start.sh [action] [project]
./start.sh help
./start.sh prepare body
./start.sh startServer body
./start.sh startPixiu body
./start.sh startTest body
./start.sh clean body
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #245: Quick Start Document
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #245:
URL: https://github.com/apache/dubbo-go-pixiu/pull/245#issuecomment-910204482
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#245](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b2b71cd) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/fa7d18a443acf52f6786e0f2f3629f7e989807a0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa7d18a) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head b2b71cd differs from pull request most recent head b5dcbab. Consider uploading reports for the commit b5dcbab to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #245 +/- ##
========================================
Coverage 40.93% 40.93%
========================================
Files 51 51
Lines 2587 2587
========================================
Hits 1059 1059
Misses 1415 1415
Partials 113 113
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fa7d18a...b5dcbab](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] mark4z commented on pull request #245: Quick Start Document
Posted by GitBox <gi...@apache.org>.
mark4z commented on pull request #245:
URL: https://github.com/apache/dubbo-go-pixiu/pull/245#issuecomment-911588455
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #245: Quick Start Document
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #245:
URL: https://github.com/apache/dubbo-go-pixiu/pull/245#issuecomment-910204482
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#245](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c1afc4) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/fa7d18a443acf52f6786e0f2f3629f7e989807a0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa7d18a) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #245 +/- ##
========================================
Coverage 40.93% 40.93%
========================================
Files 51 51
Lines 2587 2587
========================================
Hits 1059 1059
Misses 1415 1415
Partials 113 113
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fa7d18a...7c1afc4](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks merged pull request #245: Quick Start Document
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #245:
URL: https://github.com/apache/dubbo-go-pixiu/pull/245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] ztelur commented on a change in pull request #245: Quick Start Document
Posted by GitBox <gi...@apache.org>.
ztelur commented on a change in pull request #245:
URL: https://github.com/apache/dubbo-go-pixiu/pull/245#discussion_r700970638
##########
File path: README.md
##########
@@ -28,56 +28,55 @@ It supports HTTP-to-Dubbo and HTTP-to-HTTP proxy and more protocols will be supp
## Quick Start
-### 1. start provider
-
-#### 1.1 Modify the zookeeper configuration of the following files
+#### 1 cd samples dir
```
-samples/dubbogo/http/server/profiles/dev/server.yml
+cd samples/dubbo/simple
```
-#### 1.2 Switch to the root directory of dubbo-go-pixiu to execute
+we can use start.sh to run samples quickly. for more info, execute command as below for more help
```
-export CONF_PROVIDER_FILE_PATH=$PWD/samples/dubbogo/http/server/profiles/dev/server.yml
-export APP_LOG_CONF_FILE=$PWD/samples/dubbogo/http/server/profiles/dev/log.yml
+./start.sh [action] [project]
+./start.sh help
```
-
-#### 1.3 Compile the provider code
+we run body samples below step
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #245: Quick Start Document
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #245:
URL: https://github.com/apache/dubbo-go-pixiu/pull/245#issuecomment-910204482
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#245](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b5dcbab) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/fa7d18a443acf52f6786e0f2f3629f7e989807a0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa7d18a) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #245 +/- ##
========================================
Coverage 40.93% 40.93%
========================================
Files 51 51
Lines 2587 2587
========================================
Hits 1059 1059
Misses 1415 1415
Partials 113 113
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fa7d18a...b5dcbab](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #245: Quick Start Document
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #245:
URL: https://github.com/apache/dubbo-go-pixiu/pull/245#issuecomment-910204482
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#245](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b5dcbab) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/fa7d18a443acf52f6786e0f2f3629f7e989807a0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa7d18a) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #245 +/- ##
========================================
Coverage 40.93% 40.93%
========================================
Files 51 51
Lines 2587 2587
========================================
Hits 1059 1059
Misses 1415 1415
Partials 113 113
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fa7d18a...b5dcbab](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/245?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #245: Quick Start Document
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #245:
URL: https://github.com/apache/dubbo-go-pixiu/pull/245#discussion_r700749991
##########
File path: README.md
##########
@@ -28,56 +28,55 @@ It supports HTTP-to-Dubbo and HTTP-to-HTTP proxy and more protocols will be supp
## Quick Start
-### 1. start provider
-
-#### 1.1 Modify the zookeeper configuration of the following files
+#### 1 cd samples dir
```
-samples/dubbogo/http/server/profiles/dev/server.yml
+cd samples/dubbo/simple
```
-#### 1.2 Switch to the root directory of dubbo-go-pixiu to execute
+we can use start.sh to run samples quickly. for more info, execute command as below for more help
```
-export CONF_PROVIDER_FILE_PATH=$PWD/samples/dubbogo/http/server/profiles/dev/server.yml
-export APP_LOG_CONF_FILE=$PWD/samples/dubbogo/http/server/profiles/dev/log.yml
+./start.sh [action] [project]
+./start.sh help
```
-
-#### 1.3 Compile the provider code
+we run body samples below step
Review comment:
在上下各加一行空行，不要吝啬
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org