[jira] [Commented] (NIFI-530) createRemoteProcessGroupDto in DtoFactory.java does not count inactive remote ports correctly

["Matt Gilman (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506956#comment-14506956 ] 

Matt Gilman commented on NIFI-530:
----------------------------------

Thanks for the patch! One quick thing... If you create the patch using {code}git format-patch{code} it should include your user information and commit details. This way when I apply it I can simply sign off on what you provided. That way credit goes to you as the author and not myself.

> createRemoteProcessGroupDto in DtoFactory.java does not count inactive remote ports correctly
> ---------------------------------------------------------------------------------------------
>
>                 Key: NIFI-530
>                 URL: https://issues.apache.org/jira/browse/NIFI-530
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core UI
>    Affects Versions: 0.0.2
>            Reporter: Mark Latimer
>            Assignee: Matt Gilman
>            Priority: Trivial
>             Fix For: 0.1.0
>
>         Attachments: 530.diff
>
>
> createRemoteProcessGroupDto in Dtofactory.java does not increase the inactiveRemoteOutputPortCount 
> {code:title=Dtofactory.java }
>         int activeRemoteOutputPortCount = 0;
>         int inactiveRemoteOutputPortCount = 0; //not updated
>         for (final Port port : group.getOutputPorts()) {
>             outputPorts.add(createRemoteProcessGroupPortDto((RemoteGroupPort) port));
>             if (!port.getConnections().isEmpty()) {
>                 if (port.isRunning()) {
>                     activeRemoteOutputPortCount++;
>                 } else {
>                     //should be inactive like the code for incoming connections.
>                     activeRemoteOutputPortCount++;
>                 }
>             }
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)