You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/09/23 10:42:09 UTC
[GitHub] [nifi] ofirmgr opened a new pull request #4547: rename onConfigured to OnEnabled to make code more clear
ofirmgr opened a new pull request #4547:
URL: https://github.com/apache/nifi/pull/4547
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Rename onConfigured to onEnabled
#### Description of PR
rename onConfigured to onEnabled to make code more clear
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] MikeThomsen commented on pull request #4547: rename onConfigured to OnEnabled to make code more clear
Posted by GitBox <gi...@apache.org>.
MikeThomsen commented on pull request #4547:
URL: https://github.com/apache/nifi/pull/4547#issuecomment-701706721
@pvillard31 do you want me to do that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #4547: NIFI-7878 rename onConfigured to onEnabled to make code more clear
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4547:
URL: https://github.com/apache/nifi/pull/4547
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #4547: rename onConfigured to OnEnabled to make code more clear
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #4547:
URL: https://github.com/apache/nifi/pull/4547#issuecomment-698278992
Hi @ofirmgr - thanks for this contribution. Can you please create a JIRA describing the issue/improvement (https://issues.apache.org/jira/browse/NIFI)? And then update the title of this PR to prefix it with the JIRA reference? This helps us keeping track of everything. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ofirmgr edited a comment on pull request #4547: NIFI-7878 rename onConfigured to onEnabled to make code more clear
Posted by GitBox <gi...@apache.org>.
ofirmgr edited a comment on pull request #4547:
URL: https://github.com/apache/nifi/pull/4547#issuecomment-703215005
sorry for the delay. I just created jira issue and updated the title
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #4547: rename onConfigured to OnEnabled to make code more clear
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #4547:
URL: https://github.com/apache/nifi/pull/4547#issuecomment-698278992
Hi @ofirmgr - thanks for this contribution. Can you please create a JIRA describing the issue/improvement (https://issues.apache.org/jira/browse/NIFI)? And then update the title of this PR to prefix it with the JIRA reference? This helps us keeping track of everything. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ofirmgr commented on pull request #4547: NIFI-7878 rename onConfigured to onEnabled to make code more clear
Posted by GitBox <gi...@apache.org>.
ofirmgr commented on pull request #4547:
URL: https://github.com/apache/nifi/pull/4547#issuecomment-703215005
sorry for the delay. I just created jira issue and updated the titile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org