[jira] [Commented] (FLINK-3282) Add FlinkRelNode interface.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115042#comment-15115042 ] 

ASF GitHub Bot commented on FLINK-3282:
---------------------------------------

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1544#issuecomment-174471324
  
    Thanks for this PR @ChengXiangLi.
    
    This PR assumes that the code generation happens during the Calcite translation process, because the interfaces return concrete DataSet function objects. This differs from the original design document where code generation would happen in the next step, i.e., when translating the Flink RelNodes into a DataSet program.
    
    Instead of returning the DataSet functions, we could also return Calcite RexNodes (Calcite's expression trees) and generate code from that. The RexNode representation is very similar to the original TableAPI Expression representation. So porting the existing code should be rather straightforward.
    
    IMO, generating the code later would be be better separation of issues. What do you think, @ChengXiangLi and @twalthr?


> Add FlinkRelNode interface.
> ---------------------------
>
>                 Key: FLINK-3282
>                 URL: https://issues.apache.org/jira/browse/FLINK-3282
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API
>            Reporter: Chengxiang Li
>            Assignee: Chengxiang Li
>
> Add FlinkRelNode interface for physical plan translator and Flink program generator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)