You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/04/20 15:51:04 UTC

[GitHub] [spark] LuciferYang commented on a diff in pull request #40860: [SPARK-43202][YARN] Replace reflection w/ direct calling for YARN Resource API

LuciferYang commented on code in PR #40860:
URL: https://github.com/apache/spark/pull/40860#discussion_r1172791066


##########
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala:
##########
@@ -216,9 +215,8 @@ class ClientSuite extends SparkFunSuite with Matchers {
     appContext.getPriority.getPriority should be (1)
   }
 
-  test("specify a more specific type for the application") {
-    // TODO (SPARK-31733) Make this test case pass with hadoop-3
-    assume(!isYarnResourceTypesAvailable)
+  // TODO (SPARK-31733) Make this test case pass with hadoop-3
+  ignore("specify a more specific type for the application") {

Review Comment:
   https://github.com/apache/spark/pull/40877 try to fix this 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org