You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Kelven Yang <ke...@citrix.com> on 2013/04/05 00:14:03 UTC
Review Request: Finalize componentContext.xml/nonComponentContext.xml
content organization to be plugin friendly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10292/
-----------------------------------------------------------
Review request for cloudstack and Chip Childers.
Description
-------
With removal of component auto-scanning, all components are needed to configure in XML files. For OSS deployment, component declarations will be in applicationContext.xml and componentContext.xml, for non-OSS deployment, component declarations will be in applicationContext.xml and nonossComponentContext.xml
OSS/non-OSS common components should all go to applicationContext.xml, OSS or non-OSS specific components, or if there are OSS or non-OSS specific adapter configurations, they should go to componentContext.xml or nonComponentContext.xml respecitively.
If you add a big feature module, organize all components for the module into its own section.
This addresses bug CLOUDSTACK-1917.
Diffs
-----
client/tomcatconf/applicationContext.xml.in 17725f0
client/tomcatconf/componentContext.xml.in 2a4a29f
client/tomcatconf/nonossComponentContext.xml.in 13004c3
utils/src/com/cloud/utils/component/AdapterList.java PRE-CREATION
Diff: https://reviews.apache.org/r/10292/diff/
Testing
-------
manual test is done for both OSS/non-OSS
Thanks,
Kelven Yang
Re: Review Request: Finalize componentContext.xml/nonComponentContext.xml
content organization to be plugin friendly
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10292/#review18696
-----------------------------------------------------------
client/tomcatconf/componentContext.xml.in
<https://reviews.apache.org/r/10292/#comment39129>
Kelven, can you have a look at my commit on the same ticket. The Nicira and midonet gurus are missing here.
Cheers,
Hugo
- Hugo Trippaers
On April 4, 2013, 10:14 p.m., Kelven Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10292/
> -----------------------------------------------------------
>
> (Updated April 4, 2013, 10:14 p.m.)
>
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> With removal of component auto-scanning, all components are needed to configure in XML files. For OSS deployment, component declarations will be in applicationContext.xml and componentContext.xml, for non-OSS deployment, component declarations will be in applicationContext.xml and nonossComponentContext.xml
>
> OSS/non-OSS common components should all go to applicationContext.xml, OSS or non-OSS specific components, or if there are OSS or non-OSS specific adapter configurations, they should go to componentContext.xml or nonComponentContext.xml respecitively.
>
> If you add a big feature module, organize all components for the module into its own section.
>
>
> This addresses bug CLOUDSTACK-1917.
>
>
> Diffs
> -----
>
> client/tomcatconf/applicationContext.xml.in 17725f0
> client/tomcatconf/componentContext.xml.in 2a4a29f
> client/tomcatconf/nonossComponentContext.xml.in 13004c3
> utils/src/com/cloud/utils/component/AdapterList.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10292/diff/
>
>
> Testing
> -------
>
> manual test is done for both OSS/non-OSS
>
>
> Thanks,
>
> Kelven Yang
>
>
Re: Review Request: Finalize componentContext.xml/nonComponentContext.xml
content organization to be plugin friendly
Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10292/#review18776
-----------------------------------------------------------
This appears to have already been applied to 4.1.
- Chip Childers
On April 4, 2013, 10:14 p.m., Kelven Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10292/
> -----------------------------------------------------------
>
> (Updated April 4, 2013, 10:14 p.m.)
>
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> With removal of component auto-scanning, all components are needed to configure in XML files. For OSS deployment, component declarations will be in applicationContext.xml and componentContext.xml, for non-OSS deployment, component declarations will be in applicationContext.xml and nonossComponentContext.xml
>
> OSS/non-OSS common components should all go to applicationContext.xml, OSS or non-OSS specific components, or if there are OSS or non-OSS specific adapter configurations, they should go to componentContext.xml or nonComponentContext.xml respecitively.
>
> If you add a big feature module, organize all components for the module into its own section.
>
>
> This addresses bug CLOUDSTACK-1917.
>
>
> Diffs
> -----
>
> client/tomcatconf/applicationContext.xml.in 17725f0
> client/tomcatconf/componentContext.xml.in 2a4a29f
> client/tomcatconf/nonossComponentContext.xml.in 13004c3
> utils/src/com/cloud/utils/component/AdapterList.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10292/diff/
>
>
> Testing
> -------
>
> manual test is done for both OSS/non-OSS
>
>
> Thanks,
>
> Kelven Yang
>
>
Re: Review Request: Finalize componentContext.xml/nonComponentContext.xml
content organization to be plugin friendly
Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10292/#review18706
-----------------------------------------------------------
Kelven,
I'll wait to hear that you've addressed the issues that Hugo raised before committing to 4.1.
- Chip Childers
On April 4, 2013, 10:14 p.m., Kelven Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10292/
> -----------------------------------------------------------
>
> (Updated April 4, 2013, 10:14 p.m.)
>
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> With removal of component auto-scanning, all components are needed to configure in XML files. For OSS deployment, component declarations will be in applicationContext.xml and componentContext.xml, for non-OSS deployment, component declarations will be in applicationContext.xml and nonossComponentContext.xml
>
> OSS/non-OSS common components should all go to applicationContext.xml, OSS or non-OSS specific components, or if there are OSS or non-OSS specific adapter configurations, they should go to componentContext.xml or nonComponentContext.xml respecitively.
>
> If you add a big feature module, organize all components for the module into its own section.
>
>
> This addresses bug CLOUDSTACK-1917.
>
>
> Diffs
> -----
>
> client/tomcatconf/applicationContext.xml.in 17725f0
> client/tomcatconf/componentContext.xml.in 2a4a29f
> client/tomcatconf/nonossComponentContext.xml.in 13004c3
> utils/src/com/cloud/utils/component/AdapterList.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10292/diff/
>
>
> Testing
> -------
>
> manual test is done for both OSS/non-OSS
>
>
> Thanks,
>
> Kelven Yang
>
>
Re: Review Request: Finalize
componentContext.xml/nonComponentContext.xml content organization to be
plugin friendly
Posted by Chip Childers <ch...@sungard.com>.
On Sat, Apr 06, 2013 at 09:46:30AM +0000, Hugo Trippaers wrote:
> Hey Kelven,
>
> MidoNet is not in 4.1 so not surpising you couldn't find it ;-) My mistake..
>
> I've added the other components to both the standard and the non-oss build in the 4.1 branch. So everything should be ready to go now. See commit a0ffb47157c7a14429fddf926a331dc0dacc8c85.
Looks like this was pushed already by Kelven, and if I understand
correctly Hugo has applied a fix on top if it already.
>
> Cheers,
>
> Hugo
>
> > -----Original Message-----
> > From: Kelven Yang [mailto:kelven.yang@citrix.com]
> > Sent: zaterdag 6 april 2013 1:00
> > To: Chip Childers
> > Cc: Hugo Trippaers; 'dev@cloudstack.apache.org'
> > Subject: Re: Review Request: Finalize
> > componentContext.xml/nonComponentContext.xml content organization to
> > be plugin friendly
> >
> > Chip,
> > Please go ahead to apply my patch first. I couldn't find MidoNet Network
> > Guru in 4.1 branch, I think it's better for Hugo to apply his fix on top of my
> > patch on 4.1 directly
> >
> > Kelven
> >
> > On 4/5/13 11:25 AM, "Chip Childers" <ch...@sungard.com> wrote:
> >
> > >On Fri, Apr 05, 2013 at 10:47:39AM -0700, Kelven Yang wrote:
> > >> For some reason, the diff in the ticket about your change does not
> > >>show up Nicira, MidoNet Network Guru.
> > >> On quick question to confirm, Nicira/MidoNet are supposed to be
> > >>available in non-OSS build, is that correct?
> > >
> > >IIRC they are not required to be non-OSS. No libraries were introduced
> > >that are specific to those integration points, right?
> > >
>
>
RE: Review Request: Finalize
componentContext.xml/nonComponentContext.xml content organization to be
plugin friendly
Posted by Hugo Trippaers <HT...@schubergphilis.com>.
Hey Kelven,
MidoNet is not in 4.1 so not surpising you couldn't find it ;-) My mistake..
I've added the other components to both the standard and the non-oss build in the 4.1 branch. So everything should be ready to go now. See commit a0ffb47157c7a14429fddf926a331dc0dacc8c85.
Cheers,
Hugo
> -----Original Message-----
> From: Kelven Yang [mailto:kelven.yang@citrix.com]
> Sent: zaterdag 6 april 2013 1:00
> To: Chip Childers
> Cc: Hugo Trippaers; 'dev@cloudstack.apache.org'
> Subject: Re: Review Request: Finalize
> componentContext.xml/nonComponentContext.xml content organization to
> be plugin friendly
>
> Chip,
> Please go ahead to apply my patch first. I couldn't find MidoNet Network
> Guru in 4.1 branch, I think it's better for Hugo to apply his fix on top of my
> patch on 4.1 directly
>
> Kelven
>
> On 4/5/13 11:25 AM, "Chip Childers" <ch...@sungard.com> wrote:
>
> >On Fri, Apr 05, 2013 at 10:47:39AM -0700, Kelven Yang wrote:
> >> For some reason, the diff in the ticket about your change does not
> >>show up Nicira, MidoNet Network Guru.
> >> On quick question to confirm, Nicira/MidoNet are supposed to be
> >>available in non-OSS build, is that correct?
> >
> >IIRC they are not required to be non-OSS. No libraries were introduced
> >that are specific to those integration points, right?
> >
RE: Review Request: Finalize
componentContext.xml/nonComponentContext.xml content organization to be
plugin friendly
Posted by Hugo Trippaers <HT...@schubergphilis.com>.
Indeed,
Nicira components are completely open source so should be in the standard version.
Same goes for midonet components.
Cheers,
Hugo
> -----Original Message-----
> From: Chip Childers [mailto:chip.childers@sungard.com]
> Sent: vrijdag 5 april 2013 20:26
> To: Kelven Yang
> Cc: Hugo Trippaers; 'dev@cloudstack.apache.org'
> Subject: Re: Review Request: Finalize
> componentContext.xml/nonComponentContext.xml content organization to
> be plugin friendly
>
> On Fri, Apr 05, 2013 at 10:47:39AM -0700, Kelven Yang wrote:
> > For some reason, the diff in the ticket about your change does not
> > show up Nicira, MidoNet Network Guru.
> > On quick question to confirm, Nicira/MidoNet are supposed to be
> > available in non-OSS build, is that correct?
>
> IIRC they are not required to be non-OSS. No libraries were introduced that
> are specific to those integration points, right?
Re: Review Request: Finalize
componentContext.xml/nonComponentContext.xml content organization to be
plugin friendly
Posted by Kelven Yang <ke...@citrix.com>.
Chip,
Please go ahead to apply my patch first. I couldn't find MidoNet Network
Guru in 4.1 branch, I think it's better for Hugo to apply his fix on top
of my patch on 4.1 directly
Kelven
On 4/5/13 11:25 AM, "Chip Childers" <ch...@sungard.com> wrote:
>On Fri, Apr 05, 2013 at 10:47:39AM -0700, Kelven Yang wrote:
>> For some reason, the diff in the ticket about your change does not show
>>up
>> Nicira, MidoNet Network Guru.
>> On quick question to confirm, Nicira/MidoNet are supposed to be
>>available
>> in non-OSS build, is that correct?
>
>IIRC they are not required to be non-OSS. No libraries were introduced
>that are specific to those integration points, right?
>
Re: Review Request: Finalize
componentContext.xml/nonComponentContext.xml content organization to be
plugin friendly
Posted by Chip Childers <ch...@sungard.com>.
On Fri, Apr 05, 2013 at 10:47:39AM -0700, Kelven Yang wrote:
> For some reason, the diff in the ticket about your change does not show up
> Nicira, MidoNet Network Guru.
> On quick question to confirm, Nicira/MidoNet are supposed to be available
> in non-OSS build, is that correct?
IIRC they are not required to be non-OSS. No libraries were introduced
that are specific to those integration points, right?
Re: Review Request: Finalize
componentContext.xml/nonComponentContext.xml content organization to be
plugin friendly
Posted by Kelven Yang <ke...@citrix.com>.
Never mind, I found it in master.
Chip, I'll put another patch to the same review ticket.
Kelven
On 4/5/13 10:47 AM, "Kelven Yang" <ke...@citrix.com> wrote:
>For some reason, the diff in the ticket about your change does not show up
>Nicira, MidoNet Network Guru.
>On quick question to confirm, Nicira/MidoNet are supposed to be available
>in non-OSS build, is that correct?
>
>Kelven
>
>On 4/5/13 5:35 AM, "Hugo Trippaers" <HT...@schubergphilis.com> wrote:
>
>>Hey Kelven,
>>
>>I commented on your patch on the review board. Can you modify the patch
>>so all Nicira and MidoNet stuff is also in? I fixed master so you should
>>be able to use that.
>>
>>Cheers,
>>
>>Hugo
>>
>>> -----Original Message-----
>>> From: Kelven Yang [mailto:noreply@reviews.apache.org] On Behalf Of
>>> Kelven Yang
>>> Sent: vrijdag 5 april 2013 0:14
>>> To: Chip Childers
>>> Cc: cloudstack; Kelven Yang
>>> Subject: Review Request: Finalize
>>> componentContext.xml/nonComponentContext.xml content organization to
>>> be plugin friendly
>>>
>>>
>>> -----------------------------------------------------------
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/10292/
>>> -----------------------------------------------------------
>>>
>>> Review request for cloudstack and Chip Childers.
>>>
>>>
>>> Description
>>> -------
>>>
>>> With removal of component auto-scanning, all components are needed to
>>> configure in XML files. For OSS deployment, component declarations will
>>>be
>>> in applicationContext.xml and componentContext.xml, for non-OSS
>>> deployment, component declarations will be in applicationContext.xml
>>>and
>>> nonossComponentContext.xml
>>>
>>> OSS/non-OSS common components should all go to applicationContext.xml,
>>> OSS or non-OSS specific components, or if there are OSS or non-OSS
>>>specific
>>> adapter configurations, they should go to componentContext.xml or
>>> nonComponentContext.xml respecitively.
>>>
>>> If you add a big feature module, organize all components for the module
>>>into
>>> its own section.
>>>
>>>
>>> This addresses bug CLOUDSTACK-1917.
>>>
>>>
>>> Diffs
>>> -----
>>>
>>> client/tomcatconf/applicationContext.xml.in 17725f0
>>> client/tomcatconf/componentContext.xml.in 2a4a29f
>>> client/tomcatconf/nonossComponentContext.xml.in 13004c3
>>> utils/src/com/cloud/utils/component/AdapterList.java PRE-CREATION
>>>
>>> Diff: https://reviews.apache.org/r/10292/diff/
>>>
>>>
>>> Testing
>>> -------
>>>
>>> manual test is done for both OSS/non-OSS
>>>
>>>
>>> Thanks,
>>>
>>> Kelven Yang
>>
>
Re: Review Request: Finalize
componentContext.xml/nonComponentContext.xml content organization to be
plugin friendly
Posted by Kelven Yang <ke...@citrix.com>.
For some reason, the diff in the ticket about your change does not show up
Nicira, MidoNet Network Guru.
On quick question to confirm, Nicira/MidoNet are supposed to be available
in non-OSS build, is that correct?
Kelven
On 4/5/13 5:35 AM, "Hugo Trippaers" <HT...@schubergphilis.com> wrote:
>Hey Kelven,
>
>I commented on your patch on the review board. Can you modify the patch
>so all Nicira and MidoNet stuff is also in? I fixed master so you should
>be able to use that.
>
>Cheers,
>
>Hugo
>
>> -----Original Message-----
>> From: Kelven Yang [mailto:noreply@reviews.apache.org] On Behalf Of
>> Kelven Yang
>> Sent: vrijdag 5 april 2013 0:14
>> To: Chip Childers
>> Cc: cloudstack; Kelven Yang
>> Subject: Review Request: Finalize
>> componentContext.xml/nonComponentContext.xml content organization to
>> be plugin friendly
>>
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/10292/
>> -----------------------------------------------------------
>>
>> Review request for cloudstack and Chip Childers.
>>
>>
>> Description
>> -------
>>
>> With removal of component auto-scanning, all components are needed to
>> configure in XML files. For OSS deployment, component declarations will
>>be
>> in applicationContext.xml and componentContext.xml, for non-OSS
>> deployment, component declarations will be in applicationContext.xml and
>> nonossComponentContext.xml
>>
>> OSS/non-OSS common components should all go to applicationContext.xml,
>> OSS or non-OSS specific components, or if there are OSS or non-OSS
>>specific
>> adapter configurations, they should go to componentContext.xml or
>> nonComponentContext.xml respecitively.
>>
>> If you add a big feature module, organize all components for the module
>>into
>> its own section.
>>
>>
>> This addresses bug CLOUDSTACK-1917.
>>
>>
>> Diffs
>> -----
>>
>> client/tomcatconf/applicationContext.xml.in 17725f0
>> client/tomcatconf/componentContext.xml.in 2a4a29f
>> client/tomcatconf/nonossComponentContext.xml.in 13004c3
>> utils/src/com/cloud/utils/component/AdapterList.java PRE-CREATION
>>
>> Diff: https://reviews.apache.org/r/10292/diff/
>>
>>
>> Testing
>> -------
>>
>> manual test is done for both OSS/non-OSS
>>
>>
>> Thanks,
>>
>> Kelven Yang
>
RE: Review Request: Finalize
componentContext.xml/nonComponentContext.xml content organization to be
plugin friendly
Posted by Hugo Trippaers <HT...@schubergphilis.com>.
Hey Kelven,
I commented on your patch on the review board. Can you modify the patch so all Nicira and MidoNet stuff is also in? I fixed master so you should be able to use that.
Cheers,
Hugo
> -----Original Message-----
> From: Kelven Yang [mailto:noreply@reviews.apache.org] On Behalf Of
> Kelven Yang
> Sent: vrijdag 5 april 2013 0:14
> To: Chip Childers
> Cc: cloudstack; Kelven Yang
> Subject: Review Request: Finalize
> componentContext.xml/nonComponentContext.xml content organization to
> be plugin friendly
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10292/
> -----------------------------------------------------------
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> With removal of component auto-scanning, all components are needed to
> configure in XML files. For OSS deployment, component declarations will be
> in applicationContext.xml and componentContext.xml, for non-OSS
> deployment, component declarations will be in applicationContext.xml and
> nonossComponentContext.xml
>
> OSS/non-OSS common components should all go to applicationContext.xml,
> OSS or non-OSS specific components, or if there are OSS or non-OSS specific
> adapter configurations, they should go to componentContext.xml or
> nonComponentContext.xml respecitively.
>
> If you add a big feature module, organize all components for the module into
> its own section.
>
>
> This addresses bug CLOUDSTACK-1917.
>
>
> Diffs
> -----
>
> client/tomcatconf/applicationContext.xml.in 17725f0
> client/tomcatconf/componentContext.xml.in 2a4a29f
> client/tomcatconf/nonossComponentContext.xml.in 13004c3
> utils/src/com/cloud/utils/component/AdapterList.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10292/diff/
>
>
> Testing
> -------
>
> manual test is done for both OSS/non-OSS
>
>
> Thanks,
>
> Kelven Yang