You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/02/25 11:06:30 UTC
[GitHub] [maven-plugin-tools] michael-o opened a new pull request #74: [MPLUGIN-395] Upgrade Maven Reporting API/Impl to 3.1.0
michael-o opened a new pull request #74:
URL: https://github.com/apache/maven-plugin-tools/pull/74
Implicitly update MSITE to 3.11.0 and MPIR 3.2.2 for consistency with reporting.
This closes #74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski commented on a change in pull request #74: [MPLUGIN-395] Upgrade Maven Reporting API/Impl to 3.1.0
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #74:
URL: https://github.com/apache/maven-plugin-tools/pull/74#discussion_r814700273
##########
File path: maven-plugin-plugin/pom.xml
##########
@@ -350,7 +350,8 @@
<settingsFile>src/it/settings.xml</settingsFile>
<streamLogsOnFailures>true</streamLogsOnFailures>
<filterProperties>
- <sitePluginVersion>3.3</sitePluginVersion>
+ <sitePluginVersion>3.11.0</sitePluginVersion>
+ <projectInfoReportsPlugin>3.2.2</projectInfoReportsPlugin>
Review comment:
ok, agreed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski commented on a change in pull request #74: [MPLUGIN-395] Upgrade Maven Reporting API/Impl to 3.1.0
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #74:
URL: https://github.com/apache/maven-plugin-tools/pull/74#discussion_r814693581
##########
File path: maven-plugin-plugin/pom.xml
##########
@@ -350,7 +350,8 @@
<settingsFile>src/it/settings.xml</settingsFile>
<streamLogsOnFailures>true</streamLogsOnFailures>
<filterProperties>
- <sitePluginVersion>3.3</sitePluginVersion>
+ <sitePluginVersion>3.11.0</sitePluginVersion>
+ <projectInfoReportsPlugin>3.2.2</projectInfoReportsPlugin>
Review comment:
Why not use the same version like in project?
Do we want later use another version in tests then in project?
I afraid that next we update version in project but not for tests.
And how to managed version if we have plugin version from parent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slachiewicz commented on pull request #74: [MPLUGIN-395] Upgrade Maven Reporting API/Impl to 3.1.0
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #74:
URL: https://github.com/apache/maven-plugin-tools/pull/74#issuecomment-1050811133
Maybe we should have separate upgrades of one plugin and independent upgrade of it tests? To easier detect if plugin updates not affects old it tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] michael-o commented on a change in pull request #74: [MPLUGIN-395] Upgrade Maven Reporting API/Impl to 3.1.0
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #74:
URL: https://github.com/apache/maven-plugin-tools/pull/74#discussion_r814694832
##########
File path: maven-plugin-plugin/pom.xml
##########
@@ -350,7 +350,8 @@
<settingsFile>src/it/settings.xml</settingsFile>
<streamLogsOnFailures>true</streamLogsOnFailures>
<filterProperties>
- <sitePluginVersion>3.3</sitePluginVersion>
+ <sitePluginVersion>3.11.0</sitePluginVersion>
+ <projectInfoReportsPlugin>3.2.2</projectInfoReportsPlugin>
Review comment:
In most cases reactor plugins and IT plugins are decoupled. Look at other projects. Moreover, I did not want to rewrite the entire thing. You have valid concerns, but they need to be addressed on a global level for all components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] asfgit closed pull request #74: [MPLUGIN-395] Upgrade Maven Reporting API/Impl to 3.1.0
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #74:
URL: https://github.com/apache/maven-plugin-tools/pull/74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] michael-o commented on pull request #74: [MPLUGIN-395] Upgrade Maven Reporting API/Impl to 3.1.0
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #74:
URL: https://github.com/apache/maven-plugin-tools/pull/74#issuecomment-1050824506
> Maybe we should have separate upgrades of one plugin and independent upgrade of it tests? To easier detect if plugin updates not affects old it tests?
I totally agree with you and will explain why I did this in one go:
* Both API/Impl go hand on hand for Doxia 2 preparation
* When you update both reporting components ITs start to fail
Basically spilitting up is posslbe, but will leave commits in broken state that is why I have them together. In other projects I have upgraded ITs completely separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org