You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "piotaixr (via GitHub)" <gi...@apache.org> on 2023/07/31 14:36:18 UTC
[GitHub] [avro] piotaixr opened a new pull request, #2409: AVRO-3790 Provide namespace on UnknownSchemaError raise
piotaixr opened a new pull request, #2409:
URL: https://github.com/apache/avro/pull/2409
## What is the purpose of the change
If an UnknownSchemaError is raised for a nested type that should inherit its parent namespace, the default_namespace information is lost when rescuing this exception.
This prevents users of the library to use the raised exception to load the missing schema that may be defined in a separate file fore readability when handling large schema files.
## Verifying this change
This is a simple addition of information when raising an exception on encountering an unknown schema reference. The existing unit test has been updated to make sure the correct information is added to the exception.
## Documentation
- Does this pull request introduce a new feature?: YES
- Documentation for the raised exception seems to be missing from the project. I did not create it to mention the addition I made in it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] piotaixr commented on pull request #2409: AVRO-3790 Provide namespace on UnknownSchemaError raise
Posted by "piotaixr (via GitHub)" <gi...@apache.org>.
piotaixr commented on PR #2409:
URL: https://github.com/apache/avro/pull/2409#issuecomment-1667490608
HI @martin-g, thanks for the approval!
When can we expect the PR to be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] rpiotaix-tc commented on pull request #2409: AVRO-3790 Provide namespace on UnknownSchemaError raise
Posted by "rpiotaix-tc (via GitHub)" <gi...@apache.org>.
rpiotaix-tc commented on PR #2409:
URL: https://github.com/apache/avro/pull/2409#issuecomment-1721388149
Hi @tjwp
Do you know when we can expect a release containing this change?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] tjwp commented on pull request #2409: AVRO-3790 Provide namespace on UnknownSchemaError raise
Posted by "tjwp (via GitHub)" <gi...@apache.org>.
tjwp commented on PR #2409:
URL: https://github.com/apache/avro/pull/2409#issuecomment-1669978519
I've merged and also cherry-picked to the 1.11 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] tjwp merged pull request #2409: AVRO-3790 Provide namespace on UnknownSchemaError raise
Posted by "tjwp (via GitHub)" <gi...@apache.org>.
tjwp merged PR #2409:
URL: https://github.com/apache/avro/pull/2409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org