You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/07/24 22:30:14 UTC
[GitHub] [hudi] the-other-tim-brown opened a new pull request, #6201: reuse FileSystem in SparkClientFunctionalTestHarness and close it aft…
the-other-tim-brown opened a new pull request, #6201:
URL: https://github.com/apache/hudi/pull/6201
…er test
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6201: [HUDI-4456] Close FileSystem in SparkClientFunctionalTestHarness
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6201:
URL: https://github.com/apache/hudi/pull/6201#issuecomment-1193520209
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "36cc806477cb75f8c168ce0420849886ab5e650f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10289",
"triggerID" : "36cc806477cb75f8c168ce0420849886ab5e650f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 36cc806477cb75f8c168ce0420849886ab5e650f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10289)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6201: [HUDI-4456] Close FileSystem in SparkClientFunctionalTestHarness
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6201:
URL: https://github.com/apache/hudi/pull/6201#issuecomment-1193570427
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "36cc806477cb75f8c168ce0420849886ab5e650f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10289",
"triggerID" : "36cc806477cb75f8c168ce0420849886ab5e650f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 36cc806477cb75f8c168ce0420849886ab5e650f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10289)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6201: reuse FileSystem in SparkClientFunctionalTestHarness and close it aft…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6201:
URL: https://github.com/apache/hudi/pull/6201#issuecomment-1193412428
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee5654e47b5c8b837073c2e83464163a25d9dc72",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ee5654e47b5c8b837073c2e83464163a25d9dc72",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee5654e47b5c8b837073c2e83464163a25d9dc72 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6201: reuse FileSystem in SparkClientFunctionalTestHarness and close it aft…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6201:
URL: https://github.com/apache/hudi/pull/6201#issuecomment-1193413279
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee5654e47b5c8b837073c2e83464163a25d9dc72",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10288",
"triggerID" : "ee5654e47b5c8b837073c2e83464163a25d9dc72",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee5654e47b5c8b837073c2e83464163a25d9dc72 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10288)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6201: [HUDI-4456] Close FileSystem in SparkClientFunctionalTestHarness
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6201:
URL: https://github.com/apache/hudi/pull/6201#issuecomment-1193518013
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "36cc806477cb75f8c168ce0420849886ab5e650f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "36cc806477cb75f8c168ce0420849886ab5e650f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 36cc806477cb75f8c168ce0420849886ab5e650f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6201: [minor] Close FileSystem in SparkClientFunctionalTestHarness
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6201:
URL: https://github.com/apache/hudi/pull/6201#issuecomment-1193415275
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee5654e47b5c8b837073c2e83464163a25d9dc72",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10288",
"triggerID" : "ee5654e47b5c8b837073c2e83464163a25d9dc72",
"triggerType" : "PUSH"
}, {
"hash" : "4345133281042a0f46f28765b285aca51a430c1b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4345133281042a0f46f28765b285aca51a430c1b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee5654e47b5c8b837073c2e83464163a25d9dc72 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10288)
* 4345133281042a0f46f28765b285aca51a430c1b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6201: [HUDI-4456] Close FileSystem in SparkClientFunctionalTestHarness
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6201:
URL: https://github.com/apache/hudi/pull/6201#issuecomment-1193451342
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee5654e47b5c8b837073c2e83464163a25d9dc72",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10288",
"triggerID" : "ee5654e47b5c8b837073c2e83464163a25d9dc72",
"triggerType" : "PUSH"
}, {
"hash" : "4345133281042a0f46f28765b285aca51a430c1b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4345133281042a0f46f28765b285aca51a430c1b",
"triggerType" : "PUSH"
}, {
"hash" : "36cc806477cb75f8c168ce0420849886ab5e650f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10289",
"triggerID" : "36cc806477cb75f8c168ce0420849886ab5e650f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4345133281042a0f46f28765b285aca51a430c1b UNKNOWN
* 36cc806477cb75f8c168ce0420849886ab5e650f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10289)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6201: [HUDI-4456] Close FileSystem in SparkClientFunctionalTestHarness
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6201:
URL: https://github.com/apache/hudi/pull/6201#issuecomment-1193425361
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee5654e47b5c8b837073c2e83464163a25d9dc72",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10288",
"triggerID" : "ee5654e47b5c8b837073c2e83464163a25d9dc72",
"triggerType" : "PUSH"
}, {
"hash" : "4345133281042a0f46f28765b285aca51a430c1b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4345133281042a0f46f28765b285aca51a430c1b",
"triggerType" : "PUSH"
}, {
"hash" : "36cc806477cb75f8c168ce0420849886ab5e650f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "36cc806477cb75f8c168ce0420849886ab5e650f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee5654e47b5c8b837073c2e83464163a25d9dc72 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10288)
* 4345133281042a0f46f28765b285aca51a430c1b UNKNOWN
* 36cc806477cb75f8c168ce0420849886ab5e650f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] the-other-tim-brown commented on a diff in pull request #6201: [minor] Close FileSystem in SparkClientFunctionalTestHarness
Posted by GitBox <gi...@apache.org>.
the-other-tim-brown commented on code in PR #6201:
URL: https://github.com/apache/hudi/pull/6201#discussion_r928325681
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/SparkClientFunctionalTestHarness.java:
##########
@@ -208,6 +213,13 @@ public static synchronized void resetSpark() {
}
}
+ @AfterEach
+ public void closeFilesystem() throws IOException {
+ if (fileSystem != null) {
+ fileSystem.close();
Review Comment:
Updated to set it to null after close
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a diff in pull request #6201: reuse FileSystem in SparkClientFunctionalTestHarness and close it aft…
Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #6201:
URL: https://github.com/apache/hudi/pull/6201#discussion_r928321553
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/SparkClientFunctionalTestHarness.java:
##########
@@ -208,6 +213,13 @@ public static synchronized void resetSpark() {
}
}
+ @AfterEach
+ public void closeFilesystem() throws IOException {
+ if (fileSystem != null) {
+ fileSystem.close();
Review Comment:
set it to null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6201: [HUDI-4456] Close FileSystem in SparkClientFunctionalTestHarness
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6201:
URL: https://github.com/apache/hudi/pull/6201#issuecomment-1193426832
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee5654e47b5c8b837073c2e83464163a25d9dc72",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10288",
"triggerID" : "ee5654e47b5c8b837073c2e83464163a25d9dc72",
"triggerType" : "PUSH"
}, {
"hash" : "4345133281042a0f46f28765b285aca51a430c1b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4345133281042a0f46f28765b285aca51a430c1b",
"triggerType" : "PUSH"
}, {
"hash" : "36cc806477cb75f8c168ce0420849886ab5e650f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10289",
"triggerID" : "36cc806477cb75f8c168ce0420849886ab5e650f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee5654e47b5c8b837073c2e83464163a25d9dc72 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10288)
* 4345133281042a0f46f28765b285aca51a430c1b UNKNOWN
* 36cc806477cb75f8c168ce0420849886ab5e650f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10289)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan merged pull request #6201: [HUDI-4456] Close FileSystem in SparkClientFunctionalTestHarness
Posted by GitBox <gi...@apache.org>.
xushiyan merged PR #6201:
URL: https://github.com/apache/hudi/pull/6201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org