You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/08/16 02:10:42 UTC
Review Request: Adding cluster_name flag, to be displayed in the webui.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6648/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and John Sirois.
Description
-------
Screenshots included! (apparently reviewboard will only let me upload them as files)
This addresses bug MESOS-256.
https://issues.apache.org/jira/browse/MESOS-256
Diffs
-----
src/master/flags.hpp f66f0a3
src/master/http.cpp e783ac3
src/webui/master/static/home.html f3a3d0a
src/webui/master/static/index.html 421f374
Diff: https://reviews.apache.org/r/6648/diff/
Testing
-------
Local runs with --cluster_name
Thanks,
Ben Mahler
Re: Review Request: Adding cluster_name flag, to be displayed in the webui.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6648/#review10381
-----------------------------------------------------------
hoverzoom lgtm - ty!
- John Sirois
On Aug. 16, 2012, 12:11 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6648/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2012, 12:11 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and John Sirois.
>
>
> Description
> -------
>
> Screenshots included! (apparently reviewboard will only let me upload them as files)
>
> Well hoverzoom saves the day as usual: https://chrome.google.com/webstore/detail/nonjdcjchghhkdoolnlbekcfllmednbl
>
>
> This addresses bug MESOS-256.
> https://issues.apache.org/jira/browse/MESOS-256
>
>
> Diffs
> -----
>
> src/master/flags.hpp f66f0a3
> src/master/http.cpp e783ac3
> src/webui/master/static/home.html f3a3d0a
> src/webui/master/static/index.html 421f374
>
> Diff: https://reviews.apache.org/r/6648/diff/
>
>
> Testing
> -------
>
> Local runs with --cluster_name
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Adding cluster_name flag, to be displayed in the webui.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6648/#review10414
-----------------------------------------------------------
Ship it!
Shiny!
- Benjamin Hindman
On Aug. 16, 2012, 12:11 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6648/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2012, 12:11 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and John Sirois.
>
>
> Description
> -------
>
> Screenshots included! (apparently reviewboard will only let me upload them as files)
>
> Well hoverzoom saves the day as usual: https://chrome.google.com/webstore/detail/nonjdcjchghhkdoolnlbekcfllmednbl
>
>
> This addresses bug MESOS-256.
> https://issues.apache.org/jira/browse/MESOS-256
>
>
> Diffs
> -----
>
> src/master/flags.hpp f66f0a3
> src/master/http.cpp e783ac3
> src/webui/master/static/home.html f3a3d0a
> src/webui/master/static/index.html 421f374
>
> Diff: https://reviews.apache.org/r/6648/diff/
>
>
> Testing
> -------
>
> Local runs with --cluster_name
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Adding cluster_name flag, to be displayed in the webui.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6648/
-----------------------------------------------------------
(Updated Aug. 16, 2012, 12:11 a.m.)
Review request for mesos, Benjamin Hindman and John Sirois.
Description (updated)
-------
Screenshots included! (apparently reviewboard will only let me upload them as files)
Well hoverzoom saves the day as usual: https://chrome.google.com/webstore/detail/nonjdcjchghhkdoolnlbekcfllmednbl
This addresses bug MESOS-256.
https://issues.apache.org/jira/browse/MESOS-256
Diffs
-----
src/master/flags.hpp f66f0a3
src/master/http.cpp e783ac3
src/webui/master/static/home.html f3a3d0a
src/webui/master/static/index.html 421f374
Diff: https://reviews.apache.org/r/6648/diff/
Testing
-------
Local runs with --cluster_name
Thanks,
Ben Mahler