You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tiles.apache.org by mc...@apache.org on 2011/07/13 14:20:26 UTC
svn commit: r1145966 - /tiles/maven/trunk/build/tiles_checks.xml
Author: mck
Date: Wed Jul 13 12:20:25 2011
New Revision: 1145966
URL: http://svn.apache.org/viewvc?rev=1145966&view=rev
Log:
mvn site:site (checkstyle:checkstyle) didn't work anymore as our configuration wasn't compatible w/ checkstyle-5.0+
http://checkstyle.sourceforge.net/releasenotes.html
Modified:
tiles/maven/trunk/build/tiles_checks.xml
Modified: tiles/maven/trunk/build/tiles_checks.xml
URL: http://svn.apache.org/viewvc/tiles/maven/trunk/build/tiles_checks.xml?rev=1145966&r1=1145965&r2=1145966&view=diff
==============================================================================
--- tiles/maven/trunk/build/tiles_checks.xml (original)
+++ tiles/maven/trunk/build/tiles_checks.xml Wed Jul 13 12:20:25 2011
@@ -6,9 +6,9 @@
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
-
+
http://www.apache.org/licenses/LICENSE-2.0
-
+
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -35,14 +35,10 @@
<module name="ParameterName"/>
<module name="StaticVariableName"/>
<module name="TypeName"/>
- <module name="RegexpHeader">
- <property name="header" value="/\*\s*\n \*\s*\$Id.*\$\n \*\s*\n \*\s*Licensed to the Apache Software Foundation \(ASF\) under one\n \*\s*or more contributor license agreements\. See the NOTICE file\n \*\s*distributed with this work for additional information\n \*\s*regarding copyright ownership\. The ASF licenses this file\n \*\s*to you under the Apache License, Version 2\.0 \(the\n \*\s*.License.\); you may not use this file except in compliance\n \*\s*with the License\. You may obtain a copy of the License at\n \*\s*\n \*\s*http://www\.apache\.org/licenses/LICENSE\-2\.0\n \*\s*\n \*\s*Unless required by applicable law or agreed to in writing,\n \*\s*software distributed under the License is distributed on an\n \*\s*.AS IS. BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n \*\s*KIND, either express or implied\. See the License for the\n \*\s*specific language governing permissions and limitations\n \*\s*under the License\.\n \*/\s*"/>
- </module>
<module name="AvoidStarImport"/>
<module name="IllegalImport"/>
<module name="RedundantImport"/>
<module name="UnusedImports"/>
- <module name="FileLength"/>
<module name="LineLength">
<property name="ignorePattern" value="^ \* @version .*$"/>
<property name="max" value="120"/>
@@ -57,7 +53,6 @@
<module name="OperatorWrap"/>
<module name="ParenPad"/>
<module name="TypecastParenPad"/>
- <module name="TabCharacter"/>
<module name="WhitespaceAfter"/>
<module name="WhitespaceAround">
<property name="tokens" value="ASSIGN,BAND,BAND_ASSIGN,BOR,BOR_ASSIGN,BSR,BSR_ASSIGN,BXOR,BXOR_ASSIGN,COLON,DIV,DIV_ASSIGN,EQUAL,GE,GT,LAND,LCURLY,LE,LITERAL_ASSERT,LITERAL_CATCH,LITERAL_DO,LITERAL_ELSE,LITERAL_FINALLY,LITERAL_FOR,LITERAL_IF,LITERAL_RETURN,LITERAL_SYNCHRONIZED,LITERAL_TRY,LITERAL_WHILE,LOR,LT,MINUS,MINUS_ASSIGN,MOD,MOD_ASSIGN,NOT_EQUAL,PLUS,PLUS_ASSIGN,QUESTION,RCURLY,SL,SLIST,SL_ASSIGN,SR,SR_ASSIGN,STAR,STAR_ASSIGN,LITERAL_ASSERT,TYPE_EXTENSION_AND"/>
@@ -86,14 +81,19 @@
<property name="protectedAllowed" value="true"/>
</module>
<module name="ArrayTypeStyle"/>
- <module name="GenericIllegalRegexp">
- <property name="format" value="\s+$"/>
- <property name="message" value="Line has trailing spaces."/>
- </module>
<module name="TodoComment"/>
<module name="UpperEll"/>
</module>
- <module name="PackageHtml"/>
+ <module name="FileTabCharacter"/>
+ <module name="FileLength"/>
+ <module name="RegexpHeader">
+ <property name="header" value="/\*\s*\n \*\s*\$Id.*\$\n \*\s*\n \*\s*Licensed to the Apache Software Foundation \(ASF\) under one\n \*\s*or more contributor license agreements\. See the NOTICE file\n \*\s*distributed with this work for additional information\n \*\s*regarding copyright ownership\. The ASF licenses this file\n \*\s*to you under the Apache License, Version 2\.0 \(the\n \*\s*.License.\); you may not use this file except in compliance\n \*\s*with the License\. You may obtain a copy of the License at\n \*\s*\n \*\s*http://www\.apache\.org/licenses/LICENSE\-2\.0\n \*\s*\n \*\s*Unless required by applicable law or agreed to in writing,\n \*\s*software distributed under the License is distributed on an\n \*\s*.AS IS. BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n \*\s*KIND, either express or implied\. See the License for the\n \*\s*specific language governing permissions and limitations\n \*\s*under the License\.\n \*/\s*"/>
+ </module>
+ <module name="RegexpSingleline">
+ <property name="format" value="\s+$"/>
+ <property name="message" value="Line has trailing spaces."/>
+ </module>
+ <module name="JavadocPackage"/>
<module name="NewlineAtEndOfFile"/>
<module name="Translation"/>
</module>
Re: svn commit: r1145966 - /tiles/maven/trunk/build/tiles_checks.xml
Posted by Antonio Petrelli <an...@gmail.com>.
2011/7/13 mck <mc...@apache.org>
> On Wed, 2011-07-13 at 14:31 +0000, Mck wrote:
> > > Uh... did you try using this?
> > >
> >
> http://svn.apache.org/repos/asf/tiles/maven/trunk/build/tiles_checks_v5.xml
> > >
> >
> > Crap i didn't see that.
>
> So how come none of the projects are using it yet?
> (I cannot `mvn site` any tiles project currently).
>
Because I needed it only for Eclipse, and at the time there was no Maven
plugin that accepted Checkstyle 5.x.
And it doesn't work for me:
>
> > Embedded error: Failed during checkstyle configuration
> > Property 'allowStaticMemberImports' in module AvoidStarImport does not
> exist, please check the documentation
>
> But i can look into that later.
>
Again, I tried it with Eclipse and it worked, I did not test it with Maven.
But probably I missed something.
Antonio
Re: svn commit: r1145966 -
/tiles/maven/trunk/build/tiles_checks.xml
Posted by mck <mc...@apache.org>.
On Wed, 2011-07-13 at 14:31 +0000, Mck wrote:
> > Uh... did you try using this?
> >
> http://svn.apache.org/repos/asf/tiles/maven/trunk/build/tiles_checks_v5.xml
> >
>
> Crap i didn't see that.
So how come none of the projects are using it yet?
(I cannot `mvn site` any tiles project currently).
And it doesn't work for me:
> Embedded error: Failed during checkstyle configuration
> Property 'allowStaticMemberImports' in module AvoidStarImport does not exist, please check the documentation
But i can look into that later.
~mck
--
"Listen, or your tongue will make you deaf." Cherokee saying |
www.semb.wever.org | www.sesat.no | tech.finn.no |
http://xss-http-filter.sf.net
Re: svn commit: r1145966 -
/tiles/maven/trunk/build/tiles_checks.xml
Posted by Mck <mi...@wever.org>.
On Wed, 2011-07-13 at 14:23 +0200, Antonio Petrelli wrote:
> 2011/7/13 <mc...@apache.org>
>
> > Author: mck
> > Date: Wed Jul 13 12:20:25 2011
> > New Revision: 1145966
> >
> > URL: http://svn.apache.org/viewvc?rev=1145966&view=rev
> > Log:
> > mvn site:site (checkstyle:checkstyle) didn't work anymore as our
> > configuration wasn't compatible w/ checkstyle-5.0+
> > http://checkstyle.sourceforge.net/releasenotes.html
>
>
> Uh... did you try using this?
> http://svn.apache.org/repos/asf/tiles/maven/trunk/build/tiles_checks_v5.xml
>
Crap i didn't see that.
--
"Never let your sense of morals get in the way of doing what's right."
Isaac Asimov
| http://semb.wever.org | http://sesat.no
| http://tech.finn.no | Java XSS Filter
Re: svn commit: r1145966 - /tiles/maven/trunk/build/tiles_checks.xml
Posted by Antonio Petrelli <an...@gmail.com>.
2011/7/13 <mc...@apache.org>
> Author: mck
> Date: Wed Jul 13 12:20:25 2011
> New Revision: 1145966
>
> URL: http://svn.apache.org/viewvc?rev=1145966&view=rev
> Log:
> mvn site:site (checkstyle:checkstyle) didn't work anymore as our
> configuration wasn't compatible w/ checkstyle-5.0+
> http://checkstyle.sourceforge.net/releasenotes.html
Uh... did you try using this?
http://svn.apache.org/repos/asf/tiles/maven/trunk/build/tiles_checks_v5.xml
Antonio