You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/01/21 23:16:00 UTC

[jira] [Work logged] (GOBBLIN-1370) Make flow resume a restli action instead of partial update

     [ https://issues.apache.org/jira/browse/GOBBLIN-1370?focusedWorklogId=539359&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-539359 ]

ASF GitHub Bot logged work on GOBBLIN-1370:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Jan/21 23:15
            Start Date: 21/Jan/21 23:15
    Worklog Time Spent: 10m 
      Work Description: jack-moseley opened a new pull request #3211:
URL: https://github.com/apache/incubator-gobblin/pull/3211


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1370
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   
   Flow resume was previously represented as a partial update, which makes it a pretty confusing API. But restli actually supports an API for actions, which is a much simpler and more obvious way to represent a triggered action like resuming a flow.
   
   With this method, the url to request resuming a flow looks like `https://localhost:6956/gobblinservice/flowexecutions/(flowGroup:testGroup1,flowName:testFlow1,flowExecutionId:1611270235422)?action=resume`
   
   Also fixed a bug that all jobs were being set to `PENDING_RESUME` instead of only the failed/cancelled ones in `DagManager`.
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Tested locally
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 539359)
    Remaining Estimate: 0h
            Time Spent: 10m

> Make flow resume a restli action instead of partial update
> ----------------------------------------------------------
>
>                 Key: GOBBLIN-1370
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1370
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Jack Moseley
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)