You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@helix.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2019/04/01 19:43:00 UTC

[jira] [Commented] (HELIX-815) File.mkdir() may fail and cause crash.

    [ https://issues.apache.org/jira/browse/HELIX-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807114#comment-16807114 ] 

Hudson commented on HELIX-815:
------------------------------

FAILURE: Integrated in Jenkins build helix #1619 (See [https://builds.apache.org/job/helix/1619/])
[HELIX-815] fix bug to avoid potential crash (jiajunwang: rev f4b85691441d30fade4b9d9a3f85930399e7dbf7)
* (edit) helix-core/src/main/java/org/apache/helix/tools/commandtools/ZkGrep.java


> File.mkdir() may fail and cause crash.
> --------------------------------------
>
>                 Key: HELIX-815
>                 URL: https://issues.apache.org/jira/browse/HELIX-815
>             Project: Apache Helix
>          Issue Type: Bug
>          Components: helix-core
>            Reporter: bd2019us
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: 1.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Location: helix-core/src/main/java/org/apache/helix/tools/commandtools/ZkGrep.java: 584
> The File.mkdir() API requires the parent directory have to exist, otherwise a failure will occur. To ensure the safety of file creation, the File.mkdirs() is preferred as it will create the parent directory as well if needed. This is important as if it fail, program may potentially crash. Besides, mkdirs() causes no extra overhead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)