[GitHub] [airflow] potiuk commented on a change in pull request #5837: [AIRFLOW-5223] Use KinD for Kubernetes in CI

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #5837: [AIRFLOW-5223] Use KinD for Kubernetes in CI
URL: https://github.com/apache/airflow/pull/5837#discussion_r316486515
 
 

 ##########
 File path: Dockerfile
 ##########
 @@ -18,6 +18,8 @@
 # Base image for the whole Docker file
 ARG APT_DEPS_IMAGE="airflow-apt-deps-ci-slim"
 ARG PYTHON_BASE_IMAGE="python:3.6-slim-stretch"
+ARG KUBERNETES_VERSION="v1.15.0"
 
 Review comment:
   It  will be much better to move the ARGs and kubernetes installation to the 'airflow-apt-deps-ci' stage below. The first "airflow-apt-deps-ci-slim" is common for both "ci-slim" image used in static checks (much smaller) and "ci" image (used in tests). We only need kind in the latter, so it should be added there.
   
   It will also make it much faster to build on Travis as only later layers will get invalidated.
   
   Note that there is this special construct there:
   ```
   RUN if [[ "${APT_DEPS_IMAGE}" == "airflow-apt-deps-ci" ]]; then \ 
   ```
   It's a build optimisation until we switch to buildkit (currently docker build will not allow us to skip a stage that is not used and this is a trick to skip doing anything in the ci stage when slim image is built.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services