You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2012/11/28 21:17:58 UTC
[jira] [Created] (HBASE-7232) Remove HbaseMapWritable
stack created HBASE-7232:
----------------------------
Summary: Remove HbaseMapWritable
Key: HBASE-7232
URL: https://issues.apache.org/jira/browse/HBASE-7232
Project: HBase
Issue Type: Bug
Reporter: stack
Its used by hfile fileinfo only so need to convert fileinfo to remove this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7232) Remove HbaseMapWritable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-7232:
-------------------------
Status: Open (was: Patch Available)
> Remove HbaseMapWritable
> -----------------------
>
> Key: HBASE-7232
> URL: https://issues.apache.org/jira/browse/HBASE-7232
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Attachments: 7232.txt, 7232.txt, 7232v2.txt
>
>
> Its used by hfile fileinfo only so need to convert fileinfo to remove this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7232) Remove HbaseMapWritable
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507279#comment-13507279 ]
Hudson commented on HBASE-7232:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #281 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/281/])
HBASE-7232 Remove HbaseMapWritable (Revision 1415507)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HFileProtos.java
* /hbase/trunk/hbase-protocol/src/main/protobuf/HFile.proto
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/HbaseMapWritable.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileWriter.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlockIndex.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV1.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV1.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/InlineBlockWriter.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableMapReduceUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/CompoundBloomFilterWriter.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestSerialization.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileReaderV1.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileWriterV2.java
> Remove HbaseMapWritable
> -----------------------
>
> Key: HBASE-7232
> URL: https://issues.apache.org/jira/browse/HBASE-7232
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Fix For: 0.96.0
>
> Attachments: 7232.txt, 7232.txt, 7232v2.txt, 7232v3.txt, 7232v4.txt
>
>
> Its used by hfile fileinfo only so need to convert fileinfo to remove this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-7232) Remove HbaseMapWritable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reassigned HBASE-7232:
----------------------------
Assignee: stack
> Remove HbaseMapWritable
> -----------------------
>
> Key: HBASE-7232
> URL: https://issues.apache.org/jira/browse/HBASE-7232
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Attachments: 7232.txt
>
>
> Its used by hfile fileinfo only so need to convert fileinfo to remove this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7232) Remove HbaseMapWritable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-7232:
-------------------------
Attachment: 7232v2.txt
Cleaned out more Writables from hfile package.
> Remove HbaseMapWritable
> -----------------------
>
> Key: HBASE-7232
> URL: https://issues.apache.org/jira/browse/HBASE-7232
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Attachments: 7232.txt, 7232.txt, 7232v2.txt
>
>
> Its used by hfile fileinfo only so need to convert fileinfo to remove this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7232) Remove HbaseMapWritable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-7232:
-------------------------
Attachment: 7232v3.txt
Address reviewers' comments and make it actually pass tests.
> Remove HbaseMapWritable
> -----------------------
>
> Key: HBASE-7232
> URL: https://issues.apache.org/jira/browse/HBASE-7232
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Attachments: 7232.txt, 7232.txt, 7232v2.txt, 7232v3.txt
>
>
> Its used by hfile fileinfo only so need to convert fileinfo to remove this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7232) Remove HbaseMapWritable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-7232:
-------------------------
Status: Patch Available (was: Open)
> Remove HbaseMapWritable
> -----------------------
>
> Key: HBASE-7232
> URL: https://issues.apache.org/jira/browse/HBASE-7232
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Attachments: 7232.txt, 7232.txt, 7232v2.txt
>
>
> Its used by hfile fileinfo only so need to convert fileinfo to remove this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7232) Remove HbaseMapWritable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-7232:
-------------------------
Status: Patch Available (was: Open)
> Remove HbaseMapWritable
> -----------------------
>
> Key: HBASE-7232
> URL: https://issues.apache.org/jira/browse/HBASE-7232
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Attachments: 7232.txt
>
>
> Its used by hfile fileinfo only so need to convert fileinfo to remove this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7232) Remove HbaseMapWritable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-7232:
-------------------------
Attachment: 7232.txt
This is all that is needed making it work for hbase-common. Needs hbase-7215 to go in first.
> Remove HbaseMapWritable
> -----------------------
>
> Key: HBASE-7232
> URL: https://issues.apache.org/jira/browse/HBASE-7232
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Attachments: 7232.txt, 7232.txt
>
>
> Its used by hfile fileinfo only so need to convert fileinfo to remove this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7232) Remove HbaseMapWritable
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507114#comment-13507114 ]
Hadoop QA commented on HBASE-7232:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12555445/7232v4.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 99 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 26 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3424//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3424//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3424//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3424//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3424//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3424//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3424//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3424//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3424//console
This message is automatically generated.
> Remove HbaseMapWritable
> -----------------------
>
> Key: HBASE-7232
> URL: https://issues.apache.org/jira/browse/HBASE-7232
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Attachments: 7232.txt, 7232.txt, 7232v2.txt, 7232v3.txt, 7232v4.txt
>
>
> Its used by hfile fileinfo only so need to convert fileinfo to remove this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7232) Remove HbaseMapWritable
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506907#comment-13506907 ]
Elliott Clark commented on HBASE-7232:
--------------------------------------
* In HBaseObjectWritable is it cleaner to just increment the code (like on line 258) rather than putting Object in the map ?
* Would having separate implementations of the HFile.FileInfo with different reader methods be worth it ? ( hfilev1 and hvile <=v2.1 would have the writable. Everything else uses the pb. Could make removing writable version easier later)
* HFileWriterV2 is a white space only change is that intended ?
Some thoughts about code this patch happens to touch:
* Seems like most of the CompoundBloomFilter classes belong in io. Worth moving them now ?
* Should CompoundBloomFilterWriter#cacheOnWrite() be renamed to getCacheOnWrite ?
> Remove HbaseMapWritable
> -----------------------
>
> Key: HBASE-7232
> URL: https://issues.apache.org/jira/browse/HBASE-7232
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Attachments: 7232.txt, 7232.txt, 7232v2.txt
>
>
> Its used by hfile fileinfo only so need to convert fileinfo to remove this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7232) Remove HbaseMapWritable
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507139#comment-13507139 ]
Hadoop QA commented on HBASE-7232:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12555445/7232v4.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 99 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 26 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3425//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3425//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3425//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3425//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3425//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3425//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3425//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3425//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3425//console
This message is automatically generated.
> Remove HbaseMapWritable
> -----------------------
>
> Key: HBASE-7232
> URL: https://issues.apache.org/jira/browse/HBASE-7232
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Fix For: 0.96.0
>
> Attachments: 7232.txt, 7232.txt, 7232v2.txt, 7232v3.txt, 7232v4.txt
>
>
> Its used by hfile fileinfo only so need to convert fileinfo to remove this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7232) Remove HbaseMapWritable
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507154#comment-13507154 ]
Hudson commented on HBASE-7232:
-------------------------------
Integrated in HBase-TRUNK #3581 (See [https://builds.apache.org/job/HBase-TRUNK/3581/])
HBASE-7232 Remove HbaseMapWritable (Revision 1415507)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HFileProtos.java
* /hbase/trunk/hbase-protocol/src/main/protobuf/HFile.proto
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/HbaseMapWritable.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileWriter.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlockIndex.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV1.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV1.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/InlineBlockWriter.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableMapReduceUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/CompoundBloomFilterWriter.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestSerialization.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileReaderV1.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileWriterV2.java
> Remove HbaseMapWritable
> -----------------------
>
> Key: HBASE-7232
> URL: https://issues.apache.org/jira/browse/HBASE-7232
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Fix For: 0.96.0
>
> Attachments: 7232.txt, 7232.txt, 7232v2.txt, 7232v3.txt, 7232v4.txt
>
>
> Its used by hfile fileinfo only so need to convert fileinfo to remove this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7232) Remove HbaseMapWritable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-7232:
-------------------------
Attachment: 7232v4.txt
Was missing files.
> Remove HbaseMapWritable
> -----------------------
>
> Key: HBASE-7232
> URL: https://issues.apache.org/jira/browse/HBASE-7232
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Attachments: 7232.txt, 7232.txt, 7232v2.txt, 7232v3.txt, 7232v4.txt
>
>
> Its used by hfile fileinfo only so need to convert fileinfo to remove this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7232) Remove HbaseMapWritable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507132#comment-13507132 ]
stack commented on HBASE-7232:
------------------------------
Thanks [~lhofhansl]. I'm glad you think that way because I think I'll leave the blooms writable stuff alone in hfile; it is woven into the hfile metadata and through blooms themselves and would be a bunch of work to undo so I think I'll leave them as they are for 0.96. HBW backing HFileInfo was a little odd anyways. As you say was key/values of byte []. Only used here and only at the time because it was a serializable Map. No harm getting rid of it as part of the Writables purge.
I'm having to manual trigger patch builds. They broke.....
> Remove HbaseMapWritable
> -----------------------
>
> Key: HBASE-7232
> URL: https://issues.apache.org/jira/browse/HBASE-7232
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Attachments: 7232.txt, 7232.txt, 7232v2.txt, 7232v3.txt, 7232v4.txt
>
>
> Its used by hfile fileinfo only so need to convert fileinfo to remove this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7232) Remove HbaseMapWritable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-7232:
-------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Thanks for the reviews lads. Committed to trunk.
> Remove HbaseMapWritable
> -----------------------
>
> Key: HBASE-7232
> URL: https://issues.apache.org/jira/browse/HBASE-7232
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Fix For: 0.96.0
>
> Attachments: 7232.txt, 7232.txt, 7232v2.txt, 7232v3.txt, 7232v4.txt
>
>
> Its used by hfile fileinfo only so need to convert fileinfo to remove this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7232) Remove HbaseMapWritable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506984#comment-13506984 ]
stack commented on HBASE-7232:
------------------------------
bq. In HBaseObjectWritable is it cleaner to just increment the code (like on line 258) rather than putting Object in the map ?
Yes. Thanks.
bq. Would having separate implementations of the HFile.FileInfo with different reader methods be worth it ?
More pain than it is worth IMO.
bq. HFileWriterV2 is a white space only change is that intended ?
Let me remove from the next revision.
bq. Seems like most of the CompoundBloomFilter classes belong in io. Worth moving them now ?
Not as part of this patch I'd say. They need a bit of work to undo Writables. Might mess up backward compatibility moving their location. Would need to check if class name is written to the hfile).
bq. Should CompoundBloomFilterWriter#cacheOnWrite() be renamed to getCacheOnWrite ?
Yes.
Thanks for the review.
> Remove HbaseMapWritable
> -----------------------
>
> Key: HBASE-7232
> URL: https://issues.apache.org/jira/browse/HBASE-7232
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Attachments: 7232.txt, 7232.txt, 7232v2.txt
>
>
> Its used by hfile fileinfo only so need to convert fileinfo to remove this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7232) Remove HbaseMapWritable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507130#comment-13507130 ]
Lars Hofhansl commented on HBASE-7232:
--------------------------------------
Patch looks good.
Personally I have no problem with HBaseMapWritable. It will always just write a generic Map to which we can add (and remove) any field we want, and it is only used with byte[] keys and values, so nothing really gained by protobuf'ing it.
I'd be happy to change it from a generic to a concrete-type class that only allows byte[] keys and values. I think it'll make it easier to use HFiles in isolation.
(But nothing against the patch either)
> Remove HbaseMapWritable
> -----------------------
>
> Key: HBASE-7232
> URL: https://issues.apache.org/jira/browse/HBASE-7232
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Attachments: 7232.txt, 7232.txt, 7232v2.txt, 7232v3.txt, 7232v4.txt
>
>
> Its used by hfile fileinfo only so need to convert fileinfo to remove this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7232) Remove HbaseMapWritable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-7232:
-------------------------
Attachment: 7232.txt
Patch that converts hfile#fileinfo and removes HbaseMapWritable.
> Remove HbaseMapWritable
> -----------------------
>
> Key: HBASE-7232
> URL: https://issues.apache.org/jira/browse/HBASE-7232
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Attachments: 7232.txt
>
>
> Its used by hfile fileinfo only so need to convert fileinfo to remove this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira