You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/30 14:35:50 UTC

[GitHub] [spark] cloud-fan commented on issue #28041: [SPARK-30564][SQL] Improved extra new line and comment remove

cloud-fan commented on issue #28041: [SPARK-30564][SQL] Improved extra new line and comment remove
URL: https://github.com/apache/spark/pull/28041#issuecomment-606038148
 
 
   AFAIK we put placeholders of comments when generating the code, and expand placeholders to comments when printing/logging the code. Why is there a perf problem of replacing comments from the generated code?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org