[GitHub] [pulsar] tisonkun commented on pull request #17849: fix: SqliteJdbcSinkTest close in order

[GitBox <gi...@apache.org>]

tisonkun commented on PR #17849:
URL: https://github.com/apache/pulsar/pull/17849#issuecomment-1259077978

   cc @lhotari @poorbarcode 
   
   The root cause is that we run `connection.commit` concurrently in `flush` and `close` so it's possible that:
   
   ```
   db.exec("commit;") // in flush
   db.exec("commit;") // in close
   db.exec("begin;") // in flush
   ```
   
   so the second call failed with "no transaction is active".
   
   The last commit in this patch can be overkill but it's a strong guarantee that we don't run into this situation. I'm glad to learn if we have a more lightweight solution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org